On Fri, Jun 30, 2006 at 01:30:17AM +0900, Tejun Heo wrote:
> >--- libata-dev/drivers/scsi/ahci.c.orig 2006-06-28
> >09:13:10.000000000 +0200
> >+++ libata-dev/drivers/scsi/ahci.c 2006-06-29 17:29:06.000000000 +0200
> >@@ -617,10 +617,10 @@ static int ahci_softreset(struct ata_por
> > u8 *fis;
> > int rc;
> >
> >- DPRINTK("ENTER\n");
> >+ ata_port_printk(ap, ATA_MSG_TRACE, "%s: ENTER\n", __FUNCTION__);
> >
> > if (ata_port_offline(ap)) {
> >- DPRINTK("PHY reports no device\n");
> >+ ata_port_printk(ap, ATA_MSG_CMD, "PHY reports no device\n");
>
> Not really CMD, I think it should be ATA_MSG_DEBUG.
We already have VDEBUG, do we ATA_MSG_DEBUG too, and if so, what is going to be
the difference between VDEBUG and DEBUG? Pending what we have decided here, I'm
gonna correct all other cases with DEBUG.
>
> <--snip-->
> > if (ata_ratelimit())
> >- ata_port_printk(ap, KERN_INFO, "spurious interrupt "
> >+ ata_port_printk(ap, ATA_MSG_DRV, "spurious interrupt "
> > "(irq_stat 0x%x active_tag %d sactive
> > 0x%x)\n",
> > status, ap->active_tag, ap->sactive);
>
> I don't really understand why it should be DRV not INFO. Is this to
> discern between core and LLD messages?
right, this should be INFO.
Regards,
Boris.
___________________________________________________________
Telefonate ohne weitere Kosten vom PC zum PC: http://messenger.yahoo.de
-
: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
