zhao, forrest wrote:
On Mon, 2006-06-26 at 15:58 +0900, Tejun Heo wrote:
Does it make sense to add port-wide PM callbacks in this patch set?
Yes, it does. I removed those because none of the currently converted
drivers used it. Does AHCI need them? If so, I'll add them. Are you
gonna do ACPI stuff w/ those callbacks?
Yeap, both AHCI suspend/resume patch and ACPI-SATA patch need these
port-wide callbacks.
It's appreciated if you could add them in your PM patch :)
Will do after this whole thing get reviewed. I don't know much about
ACPI but don't we need to do it regardless of LLDs? If so, I think it
might be better to hook those directly into ata_eh_suspend/resume().
Other than ACPI, what do you want to do in per-port callbacks for AHCI?
--
tejun
-
: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
