On Mon, Mar 13, 2006 at 03:30:41AM -0500, Jeff Garzik wrote: > Tejun Heo wrote: > >Now that each ata_device has xfer masks, per-dev limits can be made > >per-dev instead of per-port. Make per-dev limits per-dev. > > > >Signed-off-by: Tejun Heo <htejun@xxxxxxxxx> > > Doesn't this patch break stuff? As you said in a previous patch, the > per-dev masks aren't used yet? > No, it doesn't break stuff. per-dev masks are applied in ata_dev_xfermask(). @@ -2667,6 +2670,8 @@ static unsigned int ata_dev_xfermask(str struct ata_device *d = &ap->device[i]; if (!ata_dev_present(d)) continue; + xfer_mask &= ata_pack_xfermask(d->pio_mask, d->mwdma_mask, + d->udma_mask); xfer_mask &= ata_id_xfermask(d->id); if (ata_dma_blacklisted(d)) xfer_mask &= ~(ATA_MASK_MWDMA | ATA_MASK_UDMA); -- tejun - : send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
