On Mon, Mar 13, 2006 at 03:26:37AM -0500, Jeff Garzik wrote: > NAK: > > 1) the devices are embedded with ata_port, and so all static > initialization should be done in ata_host_init(). It's only called once > for each device, as you say, anyway... no need to separate it from the > rest of the struct ata_port initialization AFAICS. I was mainly thinking of hotplug cases. dev liftime becomes different form ap lifetime in hotplug cases, so it needs reinitialization before recycling. I guess it can wait till we actually do hotplug. I'll drop this patch. > 2) there is no need to memset() [unless you are re-initializing, I suppose] ditto. -- tejun - : send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
