Tejun Heo wrote:
Printing info about IDENTIFY page used to be the responsibility of
ata_dev_read_id(). As all devices are revalidated after xfer mode
configuration, this resulted in two info messages about one device.
This patch improves ata_dump_id() such that it can be generally
useable and makes printing the responsibility of ata_dev_configure()
which has better understanding of what's going on.
The IDENTIFY info printing now looks like the following.
ata2: dev 1 cfg 49:2f00 53:0007 63:0007 64:0003 75:001f 80:00fe 81:0000 82:346b
83:7d01 84:4023 85:3469 86:3c01 87:4023 88:207f 93:0000
Signed-off-by: Tejun Heo <htejun@xxxxxxxxx>
That doesn't address the issue of an increase in log spam :) When you
read kernel messages with dmesg(8), KERN_DEBUG does nothing to decrease
the visibility of any set of messages.
So, please just decrease the current output from a doubled line to a
single line of data.
Anything more falls under the category of 'implement ap->msg_enable, and
then use ata_msg_xxx()'.
Jeff
-
: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
