On Mon, 06 Mar 2006 12:33:27 +0100 Hannes Reinecke wrote: > Hi all, > > This patch is adds ACPI support for IDE drives. It is basically a rework > of Randy Dunlaps patch for libata. And as such it has exactly the same > issues (namely it breaks layering). > > But, however, there are machines out there who do require ACPI support > even for standard IDE controllers. So we need to implement something > here; just telling the users "we're not doing it" is hardly gaining us > anything. > And I'm told that Ubuntu has something like this for ages; but of course > this one is far superior :-). > > As usual, comments etc. welcome. attachments are difficult to review/comment on. anyway: For struct GTM_buffer, I changed __u32 to u32 on request from Jeff G. and Pavel (in the libata patch). ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ I don't understand this (latter) comment: + * ide_acpi_hwif_get_handle - Get ACPI object handle for a given hwif + * @hwif: device to locate + * + * Retrieves the object handle of a given hwif. According to the ACPI + * spec is the hwif a child of the PCI device. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Jeff and Pavel also disagreed with using sscanf(dev->bus_id) to get the PCI bus:dev.func, so I used their suggestions to modify the libata code to use the following: struct pci_dev *pdev = to_pci_dev(dev); bus = pdev->bus->number; devnum = PCI_SLOT(pdev->devfn); func = PCI_FUNC(pdev->devfn); HTH and thanks for doing this. --- ~Randy Please use an email client that implements proper (compliant) threading. (You know who you are.) - : send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
