Tejun Heo wrote:
Jeff Garzik wrote:
Tejun Heo wrote:
unsigned long is way too big for sil_port[] offsets (currently the
table is 256 bytes on 64bit machines). Convert sil_port[] to u16.
Signed-off-by: Tejun Heo <htejun@xxxxxxxxx>
NAK. This just forces the compiler to promote these from u16 to
machine int (i.e. unsigned long) at addition time. Table size is a
very trivial matter.
Wouldn't that be cheaper than extra cache lines? I'm pretty sure it
would be on x86/64.
Actually, when I got this reply, I looked at it again. sil_port[] is
only used at startup, therefore performance is not an issue, and we
don't care (within reason) how big the table is. So, I would rather
leave it in native format (machine int -> unsigned long).
Jeff
-
: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
