Re: [PATCHSET] ata_piix: improve combined mode handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 28, 2006 at 01:17:27PM -0500, Jeff Garzik wrote:
> Tejun Heo wrote:
> >Hello, all.
> >
> >This patchset is against the current upstream[1] + kill illegal
> >kfree() patch[2].
> 
> 30-second review:  looks OK, though I worry about patch #6.  I'll answer 
> your questions and review in-depth later on.
> 

I'm also a little bit about #6 (the reason why it's not part of #5).
I also thought about masking with available ports but we are trusting
PCS enable bits when both bits are off (early exit when present_mask
is zero), so...

-- 
tejun
-
: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux