Re: [PATCH RFC v3 10/21] ACPI: Check _STA present bit before making CPUs not present
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: "Russell King (Oracle)" <rmk+kernel@xxxxxxxxxxxxxxx>
- Subject: Re: [PATCH RFC v3 10/21] ACPI: Check _STA present bit before making CPUs not present
- From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
- Date: Fri, 15 Dec 2023 16:18:03 +0000
- Cc: <linux-pm@xxxxxxxxxxxxxxx>, <loongarch@xxxxxxxxxxxxxxx>, <linux-acpi@xxxxxxxxxxxxxxx>, <linux-arch@xxxxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, <linux-riscv@xxxxxxxxxxxxxxxxxxx>, <kvmarm@xxxxxxxxxxxxxxx>, <x86@xxxxxxxxxx>, <acpica-devel@xxxxxxxxxxxxxxxxxxxxxxxxx>, <linux-csky@xxxxxxxxxxxxxxx>, <linux-doc@xxxxxxxxxxxxxxx>, <linux-ia64@xxxxxxxxxxxxxxx>, <linux-parisc@xxxxxxxxxxxxxxx>, Salil Mehta <salil.mehta@xxxxxxxxxx>, Jean-Philippe Brucker <jean-philippe@xxxxxxxxxx>, <jianyong.wu@xxxxxxx>, <justin.he@xxxxxxx>, James Morse <james.morse@xxxxxxx>
- In-reply-to: <E1rDOgc-00DvkW-PZ@rmk-PC.armlinux.org.uk>
- Organization: Huawei Technologies Research and Development (UK) Ltd.
- References: <ZXmn46ptis59F0CO@shell.armlinux.org.uk> <E1rDOgc-00DvkW-PZ@rmk-PC.armlinux.org.uk>
On Wed, 13 Dec 2023 12:50:02 +0000
Russell King (Oracle) <rmk+kernel@xxxxxxxxxxxxxxx> wrote:
> From: James Morse <james.morse@xxxxxxx>
>
> When called acpi_processor_post_eject() unconditionally make a CPU
> not-present and unregisters it.
>
> To add support for AML events where the CPU has become disabled, but
> remains present, the _STA method should be checked before calling
> acpi_processor_remove().
>
> Rename acpi_processor_post_eject() acpi_processor_remove_possible(), and
> check the _STA before calling.
>
> Adding the function prototype for arch_unregister_cpu() allows the
> preprocessor guards to be removed.
>
> After this change CPUs will remain registered and visible to
> user-space as offline if buggy firmware triggers an eject-request,
> but doesn't clear the corresponding _STA bits after _EJ0 has been
> called.
>
> Signed-off-by: James Morse <james.morse@xxxxxxx>
> Tested-by: Miguel Luis <miguel.luis@xxxxxxxxxx>
> Tested-by: Vishnu Pajjuri <vishnu@xxxxxxxxxxxxxxxxxxxxxx>
> Tested-by: Jianyong Wu <jianyong.wu@xxxxxxx>
LGTM
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]