Re: [PATCH 03/21] x86/topology: remove arch_*register_cpu() exports
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: "Russell King (Oracle)" <rmk+kernel@xxxxxxxxxxxxxxx>
- Subject: Re: [PATCH 03/21] x86/topology: remove arch_*register_cpu() exports
- From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
- Date: Thu, 30 Nov 2023 16:48:19 +0000
- Cc: <linux-pm@xxxxxxxxxxxxxxx>, <loongarch@xxxxxxxxxxxxxxx>, <linux-acpi@xxxxxxxxxxxxxxx>, <linux-arch@xxxxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, <linux-riscv@xxxxxxxxxxxxxxxxxxx>, <kvmarm@xxxxxxxxxxxxxxx>, <x86@xxxxxxxxxx>, <linux-csky@xxxxxxxxxxxxxxx>, <linux-doc@xxxxxxxxxxxxxxx>, <linux-ia64@xxxxxxxxxxxxxxx>, <linux-parisc@xxxxxxxxxxxxxxx>, Salil Mehta <salil.mehta@xxxxxxxxxx>, Jean-Philippe Brucker <jean-philippe@xxxxxxxxxx>, <jianyong.wu@xxxxxxx>, <justin.he@xxxxxxx>, James Morse <james.morse@xxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>
- In-reply-to: <E1r5R2r-00Csyh-7B@rmk-PC.armlinux.org.uk>
- Organization: Huawei Technologies Research and Development (UK) Ltd.
- References: <ZVyz/Ve5pPu8AWoA@shell.armlinux.org.uk> <E1r5R2r-00Csyh-7B@rmk-PC.armlinux.org.uk>
On Tue, 21 Nov 2023 13:44:05 +0000
"Russell King (Oracle)" <rmk+kernel@xxxxxxxxxxxxxxx> wrote:
> arch_register_cpu() and arch_unregister_cpu() are not used by anything
> that can be a module - they are used by drivers/base/cpu.c and
> drivers/acpi/acpi_processor.c, neither of which can be a module.
>
> Remove the exports.
>
> Reviewed-by: Gavin Shan <gshan@xxxxxxxxxx>
> Signed-off-by: Russell King (Oracle) <rmk+kernel@xxxxxxxxxxxxxxx>
I somehow ended up replying to the RFC even though you'd posted this.
On basis this might get picked up directly from this posting.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> ---
> arch/x86/kernel/topology.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/x86/kernel/topology.c b/arch/x86/kernel/topology.c
> index 0bab03130033..fcb62cfdf946 100644
> --- a/arch/x86/kernel/topology.c
> +++ b/arch/x86/kernel/topology.c
> @@ -45,13 +45,11 @@ int arch_register_cpu(int cpu)
> xc->cpu.hotpluggable = cpu > 0;
> return register_cpu(&xc->cpu, cpu);
> }
> -EXPORT_SYMBOL(arch_register_cpu);
>
> void arch_unregister_cpu(int num)
> {
> unregister_cpu(&per_cpu(cpu_devices, num).cpu);
> }
> -EXPORT_SYMBOL(arch_unregister_cpu);
> #else /* CONFIG_HOTPLUG_CPU */
>
> int __init arch_register_cpu(int num)
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]