Re: [PATCH RFC 12/22] drivers: base: Print a warning instead of panic() when register_cpu() fails
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Russell King <rmk+kernel@xxxxxxxxxxxxxxx>
- Subject: Re: [PATCH RFC 12/22] drivers: base: Print a warning instead of panic() when register_cpu() fails
- From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
- Date: Tue, 28 Nov 2023 15:05:01 +0000
- Cc: <linux-pm@xxxxxxxxxxxxxxx>, <loongarch@xxxxxxxxxxxxxxx>, <linux-acpi@xxxxxxxxxxxxxxx>, <linux-arch@xxxxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, <linux-riscv@xxxxxxxxxxxxxxxxxxx>, <kvmarm@xxxxxxxxxxxxxxx>, <x86@xxxxxxxxxx>, <linux-csky@xxxxxxxxxxxxxxx>, <linux-doc@xxxxxxxxxxxxxxx>, <linux-ia64@xxxxxxxxxxxxxxx>, <linux-parisc@xxxxxxxxxxxxxxx>, Salil Mehta <salil.mehta@xxxxxxxxxx>, Jean-Philippe Brucker <jean-philippe@xxxxxxxxxx>, <jianyong.wu@xxxxxxx>, <justin.he@xxxxxxx>, James Morse <james.morse@xxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, "Rafael J. Wysocki" <rafael@xxxxxxxxxx>, Paul Walmsley <paul.walmsley@xxxxxxxxxx>, "Palmer Dabbelt" <palmer@xxxxxxxxxxx>, Albert Ou <aou@xxxxxxxxxxxxxxxxx>
- In-reply-to: <E1r0JLg-00CTxd-31@rmk-PC.armlinux.org.uk>
- Organization: Huawei Technologies Research and Development (UK) Ltd.
- References: <ZUoRY33AAHMc5ThW@shell.armlinux.org.uk> <E1r0JLg-00CTxd-31@rmk-PC.armlinux.org.uk>
On Tue, 07 Nov 2023 10:30:20 +0000
Russell King <rmk+kernel@xxxxxxxxxxxxxxx> wrote:
> From: James Morse <james.morse@xxxxxxx>
>
> loongarch, mips, parisc, riscv and sh all print a warning if
> register_cpu() returns an error. Architectures that use
> GENERIC_CPU_DEVICES call panic() instead.
>
> Errors in this path indicate something is wrong with the firmware
> description of the platform, but the kernel is able to keep running.
>
> Downgrade this to a warning to make it easier to debug this issue.
>
> This will allow architectures that switching over to GENERIC_CPU_DEVICES
> to drop their warning, but keep the existing behaviour.
>
> Signed-off-by: James Morse <james.morse@xxxxxxx>
> Reviewed-by: Russell King (Oracle) <rmk+kernel@xxxxxxxxxxxxxxx>
> Signed-off-by: Russell King (Oracle) <rmk+kernel@xxxxxxxxxxxxxxx>
I guess there may be paths later that were never exposed because of
this panic, but any such should be fixed rather than relying on this
big hammer.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]