Re: [PATCH RFC 10/22] drivers: base: Move cpu_dev_init() after node_dev_init()
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Gavin Shan <gshan@xxxxxxxxxx>
- Subject: Re: [PATCH RFC 10/22] drivers: base: Move cpu_dev_init() after node_dev_init()
- From: "Russell King (Oracle)" <linux@xxxxxxxxxxxxxxx>
- Date: Mon, 13 Nov 2023 08:00:19 +0000
- Cc: linux-pm@xxxxxxxxxxxxxxx, loongarch@xxxxxxxxxxxxxxx, linux-acpi@xxxxxxxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-riscv@xxxxxxxxxxxxxxxxxxx, kvmarm@xxxxxxxxxxxxxxx, x86@xxxxxxxxxx, linux-csky@xxxxxxxxxxxxxxx, linux-doc@xxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-parisc@xxxxxxxxxxxxxxx, Salil Mehta <salil.mehta@xxxxxxxxxx>, Jean-Philippe Brucker <jean-philippe@xxxxxxxxxx>, jianyong.wu@xxxxxxx, justin.he@xxxxxxx, James Morse <james.morse@xxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, "Rafael J. Wysocki" <rafael@xxxxxxxxxx>
- In-reply-to: <095c2d24-735b-4ce2-ba2e-9ec2164f2237@redhat.com>
- References: <ZUoRY33AAHMc5ThW@shell.armlinux.org.uk> <E1r0JLV-00CTxS-QB@rmk-PC.armlinux.org.uk> <095c2d24-735b-4ce2-ba2e-9ec2164f2237@redhat.com>
On Mon, Nov 13, 2023 at 10:58:46AM +1000, Gavin Shan wrote:
>
>
> On 11/7/23 20:30, Russell King (Oracle) wrote:
> > From: James Morse <james.morse@xxxxxxx>
> >
> > NUMA systems require the node descriptions to be ready before CPUs are
> > registered. This is so that the node symlinks can be created in sysfs.
> >
> > Currently no NUMA platform uses GENERIC_CPU_DEVICES, meaning that CPUs
> > are registered by arch code, instead of cpu_dev_init().
> >
> > Move cpu_dev_init() after node_dev_init() so that NUMA architectures
> > can use GENERIC_CPU_DEVICES.
> >
> > Signed-off-by: James Morse <james.morse@xxxxxxx>
> > Signed-off-by: Russell King (Oracle) <rmk+kernel@xxxxxxxxxxxxxxx>
> > ---
> > Note: Jonathan's comment still needs addressing - see
> > https://lore.kernel.org/r/20230914121612.00006ac7@xxxxxxxxxx
> > ---
> > drivers/base/init.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
>
> With Jonathan's comments addressed:
That needs James' input, which is why I made the note on the patch.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]