Re: [PATCH v5 2/5] fbdev: Replace fb_pgprotect() with pgprot_framebuffer()
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Thomas Zimmermann <tzimmermann@xxxxxxx>, mpe@xxxxxxxxxxxxxx, npiggin@xxxxxxxxx, christophe.leroy@xxxxxxxxxx, arnd@xxxxxxxx, deller@xxxxxx
- Subject: Re: [PATCH v5 2/5] fbdev: Replace fb_pgprotect() with pgprot_framebuffer()
- From: Javier Martinez Canillas <javierm@xxxxxxxxxx>
- Date: Fri, 22 Sep 2023 10:28:59 +0200
- Cc: linuxppc-dev@xxxxxxxxxxxxxxxx, linux-fbdev@xxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-m68k@xxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, dri-devel@xxxxxxxxxxxxxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, Thomas Zimmermann <tzimmermann@xxxxxxx>, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
- In-reply-to: <20230922080636.26762-3-tzimmermann@suse.de>
- References: <20230922080636.26762-1-tzimmermann@suse.de> <20230922080636.26762-3-tzimmermann@suse.de>
Thomas Zimmermann <tzimmermann@xxxxxxx> writes:
> Rename the fbdev mmap helper fb_pgprotect() to pgprot_framebuffer().
> The helper sets VMA page-access flags for framebuffers in device I/O
> memory.
>
> Also clean up the helper's parameters and return value. Instead of
> the VMA instance, pass the individial parameters separately: existing
> page-access flags, the VMAs start and end addresses and the offset
> in the underlying device memory rsp file. Return the new page-access
> flags. These changes align pgprot_framebuffer() with other pgprot_()
> functions.
>
> v4:
> * fix commit message (Christophe)
> v3:
> * rename fb_pgprotect() to pgprot_framebuffer() (Arnd)
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
> Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>
> Acked-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> # m68k
> ---
Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]