Hi Ard, On 21.09.23 13:53, Ard Biesheuvel wrote:
Hello Frank, On Thu, 21 Sept 2023 at 10:15, Frank Scheiner <frank.scheiner@xxxxxx> wrote:Dear all, since v6.6-rc1 (actually introduced with [1], specific commit on [2]) the kernel build for ia64 fails like that: ```...Could one ([5]) or the other ([6]) please be included in v6.6 (or earlier) to "fix" the build problem for ia64?Do you mean by "fix" that the proposed fixes are just workarounds and not proper fixes?
Not really, or maybe a little... :-)
I don't think that is the case - the function in question does nothing except apply a quirk for one specific x86 platform.
...look, as I assumed and as you also say, the function is to "apply a quirk for one specific x86 platform". So wouldn't it be better to make that call only on x86 and leave ia64 untouched instead of putting a NOP there? I already wondered why no other architecture with ACPI failed to build? Cheers, Frank
...[5]: https://lore.kernel.org/lkml/CAJZ5v0hnNK4O_HyinvTp01YxXR7V4vzpMhf85yW9M2=52-O2Fg@xxxxxxxxxxxxxx/ [6]: https://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git/commit/?id=a0334bf78b95532cec54f56b53e8ae1bfe7e1ca1Either Arnd, Rafael or myself should send a PR to Linus to merge [6] as a fix, as it is already queued up in -next for v6.7. Or perhaps Linus doesn't mind grabbing it from here: ------------8<-------------- The following changes since commit 0bb80ecc33a8fb5a682236443c1e740d5c917d1d: Linux 6.6-rc1 (2023-09-10 16:28:41 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git tags/fix-ia64-build-for-v6.6 for you to fetch changes up to a0334bf78b95532cec54f56b53e8ae1bfe7e1ca1: acpi: Provide ia64 dummy implementation of acpi_proc_quirk_mwait_check() (2023-09-11 08:13:17 +0000) ---------------------------------------------------------------- Build fix for Itanium/ia64: - provide dummy implementation of acpi_proc_quirk_mwait_check() which was moved out of generic code into arch/x86, breaking the ia64 build ---------------------------------------------------------------- Ard Biesheuvel (1): acpi: Provide ia64 dummy implementation of acpi_proc_quirk_mwait_check() arch/ia64/kernel/acpi.c | 4 ++++ 1 file changed, 4 insertions(+)
|