Re: [PATCH v4 0/5] ppc, fbdev: Clean up fbdev mmap helper
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: "Thomas Zimmermann" <tzimmermann@xxxxxxx>, "Michael Ellerman" <mpe@xxxxxxxxxxxxxx>, "Nicholas Piggin" <npiggin@xxxxxxxxx>, "Christophe Leroy" <christophe.leroy@xxxxxxxxxx>, "Helge Deller" <deller@xxxxxx>
- Subject: Re: [PATCH v4 0/5] ppc, fbdev: Clean up fbdev mmap helper
- From: "Arnd Bergmann" <arnd@xxxxxxxx>
- Date: Wed, 20 Sep 2023 11:06:48 -0400
- Cc: linuxppc-dev@xxxxxxxxxxxxxxxx, linux-fbdev@xxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-m68k@xxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, dri-devel@xxxxxxxxxxxxxxxxxxxxx, Linux-Arch <linux-arch@xxxxxxxxxxxxxxx>
- Feedback-id: i56a14606:Fastmail
- In-reply-to: <20230912135050.17155-1-tzimmermann@suse.de>
- References: <20230912135050.17155-1-tzimmermann@suse.de>
- User-agent: Cyrus-JMAP/3.9.0-alpha0-761-gece9e40c48-fm-20230913.001-gece9e40c
On Tue, Sep 12, 2023, at 09:48, Thomas Zimmermann wrote:
> Clean up and rename fb_pgprotect() to work without struct file. Then
> refactor the implementation for PowerPC. This change has been discussed
> at [1] in the context of refactoring fbdev's mmap code.
>
> The first two patches update fbdev and replace fbdev's fb_pgprotect()
> with pgprot_framebuffer() on all architectures. The new helper's stream-
> lined interface enables more refactoring within fbdev's mmap
> implementation.
>
> Patches 3 to 5 adapt PowerPC's internal interfaces to provide
> phys_mem_access_prot() that works without struct file. Neither the
> architecture code or fbdev helpers need the parameter.
>
> v4:
> * fix commit message (Christophe)
> v3:
> * rename fb_pgrotect() to pgprot_framebuffer() (Arnd)
I had another look today, and everything look good to me now.
Whole series
Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]