Re: [PATCH 16/17] [RFC] arch: turn -Wmissing-prototypes off conditionally
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: "Stafford Horne" <shorne@xxxxxxxxx>, "Arnd Bergmann" <arnd@xxxxxxxxxx>
- Subject: Re: [PATCH 16/17] [RFC] arch: turn -Wmissing-prototypes off conditionally
- From: "Arnd Bergmann" <arnd@xxxxxxxx>
- Date: Sat, 12 Aug 2023 10:02:07 +0200
- Cc: "Andrew Morton" <akpm@xxxxxxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, "Matt Turner" <mattst88@xxxxxxxxx>, "Vineet Gupta" <vgupta@xxxxxxxxxx>, "Russell King" <linux@xxxxxxxxxxxxxxx>, "Catalin Marinas" <catalin.marinas@xxxxxxx>, "Will Deacon" <will@xxxxxxxxxx>, guoren <guoren@xxxxxxxxxx>, "Brian Cain" <bcain@xxxxxxxxxxx>, "Huacai Chen" <chenhuacai@xxxxxxxxxx>, "WANG Xuerui" <kernel@xxxxxxxxxx>, "Geert Uytterhoeven" <geert@xxxxxxxxxxxxxx>, "Michal Simek" <monstr@xxxxxxxxx>, "Thomas Bogendoerfer" <tsbogend@xxxxxxxxxxxxxxxx>, "Dinh Nguyen" <dinguyen@xxxxxxxxxx>, "Jonas Bonn" <jonas@xxxxxxxxxxxx>, "James E . J . Bottomley" <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>, "Helge Deller" <deller@xxxxxx>, "Michael Ellerman" <mpe@xxxxxxxxxxxxxx>, "Christophe Leroy" <christophe.leroy@xxxxxxxxxx>, "Palmer Dabbelt" <palmer@xxxxxxxxxxx>, "Heiko Carstens" <hca@xxxxxxxxxxxxx>, "John Paul Adrian Glaubitz" <glaubitz@xxxxxxxxxxxxxxxxxxx>, x86@xxxxxxxxxx, "Borislav Petkov" <bp@xxxxxxxxx>, "Nathan Chancellor" <nathan@xxxxxxxxxx>, "Nick Desaulniers" <ndesaulniers@xxxxxxxxxx>, "Guenter Roeck" <linux@xxxxxxxxxxxx>, "Stephen Rothwell" <sfr@xxxxxxxxxxxxxxxx>, linux-next <linux-next@xxxxxxxxxxxxxxx>, linux-alpha@xxxxxxxxxxxxxxx, linux-snps-arc@xxxxxxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, "linux-csky@xxxxxxxxxxxxxxx" <linux-csky@xxxxxxxxxxxxxxx>, linux-hexagon@xxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, loongarch@xxxxxxxxxxxxxxx, linux-m68k@xxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, "linux-openrisc@xxxxxxxxxxxxxxx" <linux-openrisc@xxxxxxxxxxxxxxx>, sparclinux@xxxxxxxxxxxxxxx, "Richard Henderson" <richard.henderson@xxxxxxxxxx>, "Ivan Kokshaysky" <ink@xxxxxxxxxxxxxxxxxxxx>, "Stefan Kristiansson" <stefan.kristiansson@xxxxxxxxxxxxx>, "Yoshinori Sato" <ysato@xxxxxxxxxxxxx>, "Rich Felker" <dalias@xxxxxxxx>, "David S . Miller" <davem@xxxxxxxxxxxxx>, "Chris Zankel" <chris@xxxxxxxxxx>, "Max Filippov" <jcmvbkbc@xxxxxxxxx>, "Christian Brauner" <brauner@xxxxxxxxxx>, "Paul Walmsley" <paul.walmsley@xxxxxxxxxx>, "Albert Ou" <aou@xxxxxxxxxxxxxxxxx>, "Youling Tang" <tangyouling@xxxxxxxxxxx>, "Tiezhu Yang" <yangtiezhu@xxxxxxxxxxx>, "Masahiro Yamada" <masahiroy@xxxxxxxxxx>, "Randy Dunlap" <rdunlap@xxxxxxxxxxxxx>, "Masami Hiramatsu" <mhiramat@xxxxxxxxxx>, "Paul E. McKenney" <paulmck@xxxxxxxxxx>, "Miguel Ojeda" <ojeda@xxxxxxxxxx>, "Zhen Lei" <thunder.leizhen@xxxxxxxxxx>, "Xin Li" <xin3.li@xxxxxxxxx>, "Nhat Pham" <nphamcs@xxxxxxxxx>, "Greg Kroah-Hartman" <gregkh@xxxxxxxxxxxxxxxxxxx>, Marc Aurèle La France <tsi@xxxxxxxxxx>, "Johannes Weiner" <hannes@xxxxxxxxxxx>, linux-parisc@xxxxxxxxxxxxxxx, linux-sh@xxxxxxxxxxxxxxx, linux-riscv@xxxxxxxxxxxxxxxxxxx
- Feedback-id: i56a14606:Fastmail
- In-reply-to: <ZNaVYh2qi0VQQKWf@antec>
- References: <20230810141947.1236730-1-arnd@kernel.org> <20230810141947.1236730-17-arnd@kernel.org> <ZNaVYh2qi0VQQKWf@antec>
- User-agent: Cyrus-JMAP/3.9.0-alpha0-624-g7714e4406d-fm-20230801.001-g7714e440
On Fri, Aug 11, 2023, at 22:09, Stafford Horne wrote:
> On Thu, Aug 10, 2023 at 04:19:34PM +0200, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@xxxxxxxx>
>> arch/openrisc/mm/fault.c:44:17: error: no previous prototype for 'do_page_fault' [-Werror=missing-prototypes]
>> arch/openrisc/mm/tlb.c:188:13: error: no previous prototype for 'tlb_init' [-Werror=missing-prototypes]
>
> I'll try to get these fixed for 6.6. I was looking at them recently but did not
> actually make any changes and just put on my TODO. Your series moves it up in
> priority and it should be easy to get the fixes out.
Thanks!
Since we already have the majority of architecture maintainers stepping
in to fix the warnings, I wonder if I should just drop my patch 16/17
completely and let the others handle it as well rather than shutting up
the warnings. Only the asm-offsets change is really needed to compile
test most of the kernel even with CONFIG_WERROR, and without that this
is just some harmless output.
Arnd
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]