Re: [PATCH v3 3/5] arch: Register fchmodat4, usually as syscall 451
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: "Alexey Gladkov" <legion@xxxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, linux-api@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, "Alexander Viro" <viro@xxxxxxxxxxxxxxxxxx>
- Subject: Re: [PATCH v3 3/5] arch: Register fchmodat4, usually as syscall 451
- From: "Arnd Bergmann" <arnd@xxxxxxxx>
- Date: Tue, 11 Jul 2023 13:31:44 +0200
- Cc: "Palmer Dabbelt" <palmer@xxxxxxxxxx>, "James E . J . Bottomley" <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>, "Arnaldo Carvalho de Melo" <acme@xxxxxxxxxx>, "Alexander Shishkin" <alexander.shishkin@xxxxxxxxxxxxxxx>, "Jens Axboe" <axboe@xxxxxxxxx>, "Benjamin Herrenschmidt" <benh@xxxxxxxxxxxxxxxxxxx>, "Christian Borntraeger" <borntraeger@xxxxxxxxxx>, "Borislav Petkov" <bp@xxxxxxxxx>, "Catalin Marinas" <catalin.marinas@xxxxxxx>, christian@xxxxxxxxxx, "Rich Felker" <dalias@xxxxxxxx>, "David S . Miller" <davem@xxxxxxxxxxxxx>, "Deepa Dinamani" <deepa.kernel@xxxxxxxxx>, "Helge Deller" <deller@xxxxxx>, "David Howells" <dhowells@xxxxxxxxxx>, fenghua.yu@xxxxxxxxx, firoz.khan@xxxxxxxxxx, "Florian Weimer" <fweimer@xxxxxxxxxx>, "Geert Uytterhoeven" <geert@xxxxxxxxxxxxxx>, glebfm@xxxxxxxxxxxx, gor@xxxxxxxxxxxxx, hare@xxxxxxxx, heiko.carstens@xxxxxxxxxx, "H. Peter Anvin" <hpa@xxxxxxxxx>, "Ivan Kokshaysky" <ink@xxxxxxxxxxxxxxxxxxxx>, jhogan@xxxxxxxxxx, "Kim Phillips" <kim.phillips@xxxxxxx>, ldv@xxxxxxxxxxxx, linux-alpha@xxxxxxxxxxxxxxx, Linux-Arch <linux-arch@xxxxxxxxxxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-m68k@xxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, linux-parisc@xxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linux-sh@xxxxxxxxxxxxxxx, "Russell King" <linux@xxxxxxxxxxxxxxx>, linuxppc-dev@xxxxxxxxxxxxxxxx, "Andy Lutomirski" <luto@xxxxxxxxxx>, "Matt Turner" <mattst88@xxxxxxxxx>, "Ingo Molnar" <mingo@xxxxxxxxxx>, "Michal Simek" <monstr@xxxxxxxxx>, "Michael Ellerman" <mpe@xxxxxxxxxxxxxx>, "Namhyung Kim" <namhyung@xxxxxxxxxx>, paul.burton@xxxxxxxx, "Paul Mackerras" <paulus@xxxxxxxxx>, "Peter Zijlstra" <peterz@xxxxxxxxxxxxx>, ralf@xxxxxxxxxxxxxx, rth@xxxxxxxxxxx, schwidefsky@xxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, stefan@xxxxxxxx, "Thomas Gleixner" <tglx@xxxxxxxxxxxxx>, "Tony Luck" <tony.luck@xxxxxxxxx>, tycho@xxxxxxxx, "Will Deacon" <will@xxxxxxxxxx>, x86@xxxxxxxxxx, "Yoshinori Sato" <ysato@xxxxxxxxxxxxx>
- Feedback-id: i56a14606:Fastmail
- In-reply-to: <e48c4d4046de97205fd52a73f77e9b203c3b871e.1689074739.git.legion@kernel.org>
- References: <87o8pscpny.fsf@oldenburg2.str.redhat.com> <cover.1689074739.git.legion@kernel.org> <e48c4d4046de97205fd52a73f77e9b203c3b871e.1689074739.git.legion@kernel.org>
- User-agent: Cyrus-JMAP/3.9.0-alpha0-531-gfdfa13a06d-fm-20230703.001-gfdfa13a0
On Tue, Jul 11, 2023, at 13:25, Alexey Gladkov wrote:
> From: Palmer Dabbelt <palmer@xxxxxxxxxx>
>
> This registers the new fchmodat4 syscall in most places as nuber 451,
> with alpha being the exception where it's 561. I found all these sites
> by grepping for fspick, which I assume has found me everything.
>
> Signed-off-by: Palmer Dabbelt <palmer@xxxxxxxxxx>
> Signed-off-by: Alexey Gladkov <legion@xxxxxxxxxx>
In linux-6.5-rc1, number 451 is used for __NR_cachestat, the
next free one at the moment is 452.
> arch/arm/tools/syscall.tbl | 1 +
> arch/arm64/include/asm/unistd32.h | 2 ++
Unfortunately, you still also need to change __NR_compat_syscalls
in arch/arm64/include/asm/unistd.h. Aside from these two issues,
your patch is the correct way to hook up a new syscall.
Arnd
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]