Re: [PATCH v4 01/13] kexec: consolidate kexec and crash options into kernel/Kconfig.kexec
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: "Eric DeVolder" <eric.devolder@xxxxxxxxxx>, "Russell King" <linux@xxxxxxxxxxxxxxx>, "Catalin Marinas" <catalin.marinas@xxxxxxx>, "Will Deacon" <will@xxxxxxxxxx>, "Huacai Chen" <chenhuacai@xxxxxxxxxx>, "Geert Uytterhoeven" <geert@xxxxxxxxxxxxxx>, "Thomas Bogendoerfer" <tsbogend@xxxxxxxxxxxxxxxx>, "James E . J . Bottomley" <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>, "Helge Deller" <deller@xxxxxx>, "Yoshinori Sato" <ysato@xxxxxxxxxxxxx>, "Rich Felker" <dalias@xxxxxxxx>, "John Paul Adrian Glaubitz" <glaubitz@xxxxxxxxxxxxxxxxxxx>, "Thomas Gleixner" <tglx@xxxxxxxxxxxxx>, "Ingo Molnar" <mingo@xxxxxxxxxx>, "Borislav Petkov" <bp@xxxxxxxxx>, "Dave Hansen" <dave.hansen@xxxxxxxxxxxxxxx>, x86@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, loongarch@xxxxxxxxxxxxxxx, linux-m68k@xxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, linux-parisc@xxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-riscv@xxxxxxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linux-sh@xxxxxxxxxxxxxxx
- Subject: Re: [PATCH v4 01/13] kexec: consolidate kexec and crash options into kernel/Kconfig.kexec
- From: "Arnd Bergmann" <arnd@xxxxxxxx>
- Date: Thu, 06 Jul 2023 14:18:36 +0200
- Cc: "WANG Xuerui" <kernel@xxxxxxxxxx>, "Michael Ellerman" <mpe@xxxxxxxxxxxxxx>, "Nicholas Piggin" <npiggin@xxxxxxxxx>, "Christophe Leroy" <christophe.leroy@xxxxxxxxxx>, "Paul Walmsley" <paul.walmsley@xxxxxxxxxx>, "Palmer Dabbelt" <palmer@xxxxxxxxxxx>, "Albert Ou" <aou@xxxxxxxxxxxxxxxxx>, "Heiko Carstens" <hca@xxxxxxxxxxxxx>, gor@xxxxxxxxxxxxx, "Alexander Gordeev" <agordeev@xxxxxxxxxxxxx>, borntraeger@xxxxxxxxxxxxx, "Sven Schnelle" <svens@xxxxxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, "Kees Cook" <keescook@xxxxxxxxxxxx>, "Paul E. McKenney" <paulmck@xxxxxxxxxx>, "Peter Zijlstra" <peterz@xxxxxxxxxxxxx>, "Frederic Weisbecker" <frederic@xxxxxxxxxx>, "Andrew Morton" <akpm@xxxxxxxxxxxxxxxxxxxx>, "Ard Biesheuvel" <ardb@xxxxxxxxxx>, "Sami Tolvanen" <samitolvanen@xxxxxxxxxx>, "Juerg Haefliger" <juerg.haefliger@xxxxxxxxxxxxx>, "Russell King" <rmk+kernel@xxxxxxxxxxxxxxx>, "Linus Walleij" <linus.walleij@xxxxxxxxxx>, "Sebastian Reichel" <sebastian.reichel@xxxxxxxxxxxxx>, "Mike Rapoport" <rppt@xxxxxxxxxx>, "Kirill A. Shutemov" <kirill.shutemov@xxxxxxxxxxxxxxx>, "Anshuman Khandual" <anshuman.khandual@xxxxxxx>, "Zi Yan" <ziy@xxxxxxxxxx>, "Masahiro Yamada" <masahiroy@xxxxxxxxxx>, "Nick Desaulniers" <ndesaulniers@xxxxxxxxxx>, "Masami Hiramatsu" <mhiramat@xxxxxxxxxx>, "Miguel Ojeda" <ojeda@xxxxxxxxxx>, "Zhen Lei" <thunder.leizhen@xxxxxxxxxx>, "Xin Li" <xin3.li@xxxxxxxxx>, "Tejun Heo" <tj@xxxxxxxxxx>, "Greg Kroah-Hartman" <gregkh@xxxxxxxxxxxxxxxxxxx>, tsi@xxxxxxxxxx, "Baoquan He" <bhe@xxxxxxxxxx>, hbathini@xxxxxxxxxxxxx, sourabhjain@xxxxxxxxxxxxx, "Boris Ostrovsky" <boris.ostrovsky@xxxxxxxxxx>, "Konrad Rzeszutek Wilk" <konrad.wilk@xxxxxxxxxx>
- Feedback-id: i56a14606:Fastmail
- In-reply-to: <20230705142004.3605799-2-eric.devolder@oracle.com>
- References: <20230705142004.3605799-1-eric.devolder@oracle.com> <20230705142004.3605799-2-eric.devolder@oracle.com>
- User-agent: Cyrus-JMAP/3.9.0-alpha0-531-gfdfa13a06d-fm-20230703.001-gfdfa13a0
On Wed, Jul 5, 2023, at 16:19, Eric DeVolder wrote:
> +
> +config CRASH_DUMP
> + bool "kernel crash dumps"
> + depends on ARCH_SUPPORTS_CRASH_DUMP
> + select CRASH_CORE
> + select KEXEC
Today's linux-next now runs into a warning on arm64 and
presumably others, with the same problem as on arm earlier:
WARNING: unmet direct dependencies detected for KEXEC
Depends on [n]: ARCH_SUPPORTS_KEXEC [=n]
Selected by [y]:
- CRASH_DUMP [=y] && ARCH_SUPPORTS_CRASH_DUMP [=y]
I think the easiest way to make this reliable would be
this fixup:
diff --git a/kernel/Kconfig.kexec b/kernel/Kconfig.kexec
index d82a7ce59c051..e58ca6128d6ee 100644
--- a/kernel/Kconfig.kexec
+++ b/kernel/Kconfig.kexec
@@ -91,6 +91,7 @@ config KEXEC_JUMP
config CRASH_DUMP
bool "kernel crash dumps"
depends on ARCH_SUPPORTS_CRASH_DUMP
+ depends on ARCH_SUPPORTS_KEXEC
select CRASH_CORE
select KEXEC
help
Arnd
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]
