Re: [v3,17/19] arch/sparc: Implement fb_is_primary_device() in source file
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: "Guenter Roeck" <linux@xxxxxxxxxxxx>, "Thomas Zimmermann" <tzimmermann@xxxxxxx>
- Subject: Re: [v3,17/19] arch/sparc: Implement fb_is_primary_device() in source file
- From: "Arnd Bergmann" <arnd@xxxxxxxx>
- Date: Wed, 28 Jun 2023 12:01:58 +0200
- Cc: "Daniel Vetter" <daniel.vetter@xxxxxxxx>, "Helge Deller" <deller@xxxxxx>, "Javier Martinez Canillas" <javierm@xxxxxxxxxx>, "Greg Kroah-Hartman" <gregkh@xxxxxxxxxxxxxxxxxxx>, Linux-Arch <linux-arch@xxxxxxxxxxxxxxx>, linux-fbdev@xxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-parisc@xxxxxxxxxxxxxxx, linux-sh@xxxxxxxxxxxxxxx, x86@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, dri-devel@xxxxxxxxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, linux-m68k@xxxxxxxxxxxxxxx, loongarch@xxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, linux-snps-arc@xxxxxxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, "David S . Miller" <davem@xxxxxxxxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, "Mark Rutland" <mark.rutland@xxxxxxx>, "Peter Zijlstra (Intel)" <peterz@xxxxxxxxxxxxx>, "KKees Cook" <keescook@xxxxxxxxxxxx>, "ees Cook" <keescook@xxxxxxxxxxxx>
- Feedback-id: i56a14606:Fastmail
- In-reply-to: <d9ffc44c-c4ae-4f01-bc0b-ee5359a24a0a@app.fastmail.com>
- References: <20230417125651.25126-18-tzimmermann@suse.de> <c525adc9-6623-4660-8718-e0c9311563b8@roeck-us.net> <55130a50-d129-4336-99ce-3be4229b1c7d@app.fastmail.com> <d4156e51-102f-36b4-e42c-938268b4b608@roeck-us.net> <d9ffc44c-c4ae-4f01-bc0b-ee5359a24a0a@app.fastmail.com>
- User-agent: Cyrus-JMAP/3.9.0-alpha0-499-gf27bbf33e2-fm-20230619.001-gf27bbf33
On Sat, Jun 24, 2023, at 16:21, Arnd Bergmann wrote:
> On Sat, Jun 24, 2023, at 15:26, Guenter Roeck wrote:
>> On 6/24/23 02:27, Arnd Bergmann wrote:
>>> On Sat, Jun 24, 2023, at 03:55, Guenter Roeck wrote:
>>>>
>>>> ERROR: modpost: "__xchg_called_with_bad_pointer" [lib/atomic64_test.ko]
>>>> undefined!
>>>
>>> These all look like old bugs that would be trivially fixed if
>>> anyone cared about sparc.
>>>
>>
>> Odd argument, given that this _is_ a sparc patch. Those may be old
>> bugs, but at least in 6.4-rc7 sparc64:allmodconfig does at least compile.
>
> I think we clearly want to fix the fbdev regression you found, and
> maybe bisect the atomic64_test as well to see if that was caused by
> a recent patch to get it into a working state again.
I have bisected this as well now and sent a trivial fix, see
https://lore.kernel.org/lkml/20230628094938.2318171-1-arnd@xxxxxxxxxx/
Arnd
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]
