Re: [patch 02/17] x86/cpu: Switch to arch_cpu_finalize_init()
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: LKML <linux-kernel@xxxxxxxxxxxxxxx>
- Subject: Re: [patch 02/17] x86/cpu: Switch to arch_cpu_finalize_init()
- From: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
- Date: Wed, 14 Jun 2023 11:53:50 +0200
- Cc: x86@xxxxxxxxxx, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Nikolay Borisov <nik.borisov@xxxxxxxx>, "Ahmed S. Darwish" <darwi@xxxxxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Russell King <linux@xxxxxxxxxxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, Huacai Chen <chenhuacai@xxxxxxxxxx>, WANG Xuerui <kernel@xxxxxxxxxx>, loongarch@xxxxxxxxxxxxxxx, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>, linux-m68k@xxxxxxxxxxxxxxx, Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>, linux-mips@xxxxxxxxxxxxxxx, Yoshinori Sato <ysato@xxxxxxxxxxxxx>, Rich Felker <dalias@xxxxxxxx>, John Paul Adrian Glaubitz <glaubitz@xxxxxxxxxxxxxxxxxxx>, linux-sh@xxxxxxxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxxxxx>, sparclinux@xxxxxxxxxxxxxxx, Richard Weinberger <richard@xxxxxx>, Anton Ivanov <anton.ivanov@xxxxxxxxxxxxxxxxxx>, Johannes Berg <johannes@xxxxxxxxxxxxxxxx>, linux-um@xxxxxxxxxxxxxxxxxxx, Richard Henderson <richard.henderson@xxxxxxxxxx>, "James E.J. Bottomley" <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Chris Zankel <chris@xxxxxxxxxx>, Tom Lendacky <thomas.lendacky@xxxxxxx>
- In-reply-to: <20230613224545.019583869@linutronix.de>
- References: <20230613223827.532680283@linutronix.de> <20230613224545.019583869@linutronix.de>
On Wed, Jun 14 2023 at 01:39, Thomas Gleixner wrote:
> + /*
> + * identify_boot_cpu() initialized SMT support information, let the
> + * core code know.
> + */
> + cpu_smt_check_topology();
> +
> + if (!IS_ENABLED(CONFIG_SMP)) {
> + pr_info("CPU: ");
> + print_cpu_info(&boot_cpu_data);
> + }
> +
> + arch_smt_update();
> +
> + cpu_select_mitigations();
That's the wrong order. mitigations must come before the smt
update. Thanks to Boris for spotting it.
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]