Re: [PATCH v6 5/6] fbdev: Move framebuffer I/O helpers into <asm/fb.h>
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: "kernel test robot" <lkp@xxxxxxxxx>, "Thomas Zimmermann" <tzimmermann@xxxxxxx>, "Helge Deller" <deller@xxxxxx>, "Geert Uytterhoeven" <geert@xxxxxxxxxxxxxx>, "Javier Martinez Canillas" <javierm@xxxxxxxxxx>, "Daniel Vetter" <daniel@xxxxxxxx>, "Vineet Gupta" <vgupta@xxxxxxxxxx>, "Huacai Chen" <chenhuacai@xxxxxxxxxx>, "WANG Xuerui" <kernel@xxxxxxxxxx>, "David S . Miller" <davem@xxxxxxxxxxxxx>, "James E . J . Bottomley" <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>, "Sam Ravnborg" <sam@xxxxxxxxxxxx>, suijingfeng@xxxxxxxxxxx
- Subject: Re: [PATCH v6 5/6] fbdev: Move framebuffer I/O helpers into <asm/fb.h>
- From: "Arnd Bergmann" <arnd@xxxxxxxx>
- Date: Wed, 10 May 2023 16:15:46 +0200
- Cc: oe-kbuild-all@xxxxxxxxxxxxxxx, Linux-Arch <linux-arch@xxxxxxxxxxxxxxx>, linux-fbdev@xxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-parisc@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, dri-devel@xxxxxxxxxxxxxxxxxxxxx, linux-m68k@xxxxxxxxxxxxxxx, loongarch@xxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, linux-snps-arc@xxxxxxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
- Feedback-id: i56a14606:Fastmail
- In-reply-to: <202305102136.eMjTSPwH-lkp@intel.com>
- References: <20230510110557.14343-6-tzimmermann@suse.de> <202305102136.eMjTSPwH-lkp@intel.com>
- User-agent: Cyrus-JMAP/3.9.0-alpha0-415-gf2b17fe6c3-fm-20230503.001-gf2b17fe6
On Wed, May 10, 2023, at 16:03, kernel test robot wrote:
>
> cc1: warning: arch/sh/include/mach-hp6xx: No such file or directory
> [-Wmissing-include-dirs]
> cc1: warning: arch/sh/include/mach-hp6xx: No such file or directory
> [-Wmissing-include-dirs]
> In file included from drivers/video/fbdev/hitfb.c:27:
> drivers/video/fbdev/hitfb.c: In function 'hitfb_accel_wait':
>>> arch/sh/include/asm/hd64461.h:18:33: warning: passing argument 1 of 'fb_readw' makes pointer from integer without a cast [-Wint-conversion]
> 18 | #define HD64461_IO_OFFSET(x) (HD64461_IOBASE + (x))
> | ^~~~~~~~~~~~~~~~~~~~~~
> | |
> | unsigned int
> arch/sh/include/asm/hd64461.h:93:33: note: in expansion of macro
> 'HD64461_IO_OFFSET'
> 93 | #define HD64461_GRCFGR HD64461_IO_OFFSET(0x1044)
> /* Accelerator Configuration Register */
> | ^~~~~~~~~~~~~~~~~
> drivers/video/fbdev/hitfb.c:47:25: note: in expansion of macro
> 'HD64461_GRCFGR'
> 47 | while (fb_readw(HD64461_GRCFGR) &
> HD64461_GRCFGR_ACCSTATUS) ;
I think that's a preexisting bug and I have no idea what the
correct solution is. Looking for HD64461 shows it being used
both with inw/outw and readw/writew, so there is no way to have
the correct type. The sh __raw_readw() definition hides this bug,
but that is a problem with arch/sh and it probably hides others
as well.
Arnd
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]