Re: [PATCH v3 00/19] arch: Consolidate <asm/fb.h>
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: "Thomas Zimmermann" <tzimmermann@xxxxxxx>, "Daniel Vetter" <daniel.vetter@xxxxxxxx>, "Helge Deller" <deller@xxxxxx>, "Javier Martinez Canillas" <javierm@xxxxxxxxxx>, "Greg Kroah-Hartman" <gregkh@xxxxxxxxxxxxxxxxxxx>
- Subject: Re: [PATCH v3 00/19] arch: Consolidate <asm/fb.h>
- From: "Arnd Bergmann" <arnd@xxxxxxxx>
- Date: Mon, 17 Apr 2023 16:12:15 +0200
- Cc: Linux-Arch <linux-arch@xxxxxxxxxxxxxxx>, linux-fbdev@xxxxxxxxxxxxxxx, dri-devel@xxxxxxxxxxxxxxxxxxxxx, linux-snps-arc@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, loongarch@xxxxxxxxxxxxxxx, linux-m68k@xxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, linux-parisc@xxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-sh@xxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, x86@xxxxxxxxxx
- Feedback-id: i56a14606:Fastmail
- In-reply-to: <20230417125651.25126-1-tzimmermann@suse.de>
- References: <20230417125651.25126-1-tzimmermann@suse.de>
- User-agent: Cyrus-JMAP/3.9.0-alpha0-372-g43825cb665-fm-20230411.003-g43825cb6
On Mon, Apr 17, 2023, at 14:56, Thomas Zimmermann wrote:
> Various architectures provide <asm/fb.h> with helpers for fbdev
> framebuffer devices. Share the contained code where possible. There
> is already <asm-generic/fb.h>, which implements generic (as in
> 'empty') functions of the fbdev helpers. The header was added in
> commit aafe4dbed0bf ("asm-generic: add generic versions of common
> headers"), but never used.
>
> Each per-architecture header file declares and/or implements fbdev
> helpers and defines a preprocessor token for each. The generic
> header then provides the remaining helpers. It works like the I/O
> helpers in <asm/io.h>.
Looks all good to me,
Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
Arnd
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]