Re: [PATCH v2 15/19] arch/powerpc: Implement <asm/fb.h> with generic helpers
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Thomas Zimmermann <tzimmermann@xxxxxxx>, arnd@xxxxxxxx, daniel.vetter@xxxxxxxx, deller@xxxxxx, javierm@xxxxxxxxxx, gregkh@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [PATCH v2 15/19] arch/powerpc: Implement <asm/fb.h> with generic helpers
- From: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
- Date: Wed, 12 Apr 2023 16:17:59 +1000
- Cc: linux-arch@xxxxxxxxxxxxxxx, linux-fbdev@xxxxxxxxxxxxxxx, dri-devel@xxxxxxxxxxxxxxxxxxxxx, linux-snps-arc@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, loongarch@xxxxxxxxxxxxxxx, linux-m68k@xxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, linux-parisc@xxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-sh@xxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, x86@xxxxxxxxxx, Thomas Zimmermann <tzimmermann@xxxxxxx>, Nicholas Piggin <npiggin@xxxxxxxxx>, Christophe Leroy <christophe.leroy@xxxxxxxxxx>
- In-reply-to: <20230406143019.6709-16-tzimmermann@suse.de>
- References: <20230406143019.6709-1-tzimmermann@suse.de> <20230406143019.6709-16-tzimmermann@suse.de>
Thomas Zimmermann <tzimmermann@xxxxxxx> writes:
> Replace the architecture's fb_is_primary_device() with the generic
> one from <asm-generic/fb.h>. No functional changes.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
> Cc: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
> Cc: Nicholas Piggin <npiggin@xxxxxxxxx>
> Cc: Christophe Leroy <christophe.leroy@xxxxxxxxxx>
> ---
> arch/powerpc/include/asm/fb.h | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
Looks fine.
Acked-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx> (powerpc)
cheers
> diff --git a/arch/powerpc/include/asm/fb.h b/arch/powerpc/include/asm/fb.h
> index 6541ab77c5b9..5f1a2e5f7654 100644
> --- a/arch/powerpc/include/asm/fb.h
> +++ b/arch/powerpc/include/asm/fb.h
> @@ -2,8 +2,8 @@
> #ifndef _ASM_FB_H_
> #define _ASM_FB_H_
>
> -#include <linux/fb.h>
> #include <linux/fs.h>
> +
> #include <asm/page.h>
>
> static inline void fb_pgprotect(struct file *file, struct vm_area_struct *vma,
> @@ -13,10 +13,8 @@ static inline void fb_pgprotect(struct file *file, struct vm_area_struct *vma,
> vma->vm_end - vma->vm_start,
> vma->vm_page_prot);
> }
> +#define fb_pgprotect fb_pgprotect
>
> -static inline int fb_is_primary_device(struct fb_info *info)
> -{
> - return 0;
> -}
> +#include <asm-generic/fb.h>
>
> #endif /* _ASM_FB_H_ */
> --
> 2.40.0
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]