Re: [PATCH v3 10/24] sparc: Remove COMMAND_LINE_SIZE from uapi
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: WANG Xuerui <kernel@xxxxxxxxxx>, Alexandre Ghiti <alexghiti@xxxxxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, Richard Henderson <richard.henderson@xxxxxxxxxx>, Ivan Kokshaysky <ink@xxxxxxxxxxxxxxxxxxxx>, Matt Turner <mattst88@xxxxxxxxx>, Vineet Gupta <vgupta@xxxxxxxxxx>, Russell King <linux@xxxxxxxxxxxxxxx>, Catalin Marinas <catalin.marinas@xxxxxxx>, Will Deacon <will@xxxxxxxxxx>, Huacai Chen <chenhuacai@xxxxxxxxxx>, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>, Michal Simek <monstr@xxxxxxxxx>, Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>, "James E . J . Bottomley" <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>, Helge Deller <deller@xxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Nicholas Piggin <npiggin@xxxxxxxxx>, Christophe Leroy <christophe.leroy@xxxxxxxxxx>, Paul Walmsley <paul.walmsley@xxxxxxxxxx>, Palmer Dabbelt <palmer@xxxxxxxxxxx>, Albert Ou <aou@xxxxxxxxxxxxxxxxx>, Heiko Carstens <hca@xxxxxxxxxxxxx>, Vasily Gorbik <gor@xxxxxxxxxxxxx>, Alexander Gordeev <agordeev@xxxxxxxxxxxxx>, Christian Borntraeger <borntraeger@xxxxxxxxxxxxx>, Sven Schnelle <svens@xxxxxxxxxxxxx>, Yoshinori Sato <ysato@xxxxxxxxxxxxx>, Rich Felker <dalias@xxxxxxxx>, "David S . Miller" <davem@xxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, <x86@xxxxxxxxxx>, "H . Peter Anvin" <hpa@xxxxxxxxx>, Chris Zankel <chris@xxxxxxxxxx>, Max Filippov <jcmvbkbc@xxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, <linux-doc@xxxxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, <linux-alpha@xxxxxxxxxxxxxxx>, <linux-snps-arc@xxxxxxxxxxxxxxxxxxx>, <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, <linux-ia64@xxxxxxxxxxxxxxx>, <loongarch@xxxxxxxxxxxxxxx>, <linux-m68k@xxxxxxxxxxxxxxx>, <linux-mips@xxxxxxxxxxxxxxx>, <linux-parisc@xxxxxxxxxxxxxxx>, <linuxppc-dev@xxxxxxxxxxxxxxxx>, <linux-riscv@xxxxxxxxxxxxxxxxxxx>, <linux-s390@xxxxxxxxxxxxxxx>, <linux-sh@xxxxxxxxxxxxxxx>, <sparclinux@xxxxxxxxxxxxxxx>, <linux-xtensa@xxxxxxxxxxxxxxxx>, <linux-arch@xxxxxxxxxxxxxxx>
- Subject: Re: [PATCH v3 10/24] sparc: Remove COMMAND_LINE_SIZE from uapi
- From: Sergey Shtylyov <s.shtylyov@xxxxxx>
- Date: Tue, 14 Feb 2023 12:11:09 +0300
- Cc: Palmer Dabbelt <palmer@xxxxxxxxxxxx>
- In-reply-to: <f3db61bb-5c89-2724-769f-9d606f587f92@xen0n.name>
- Organization: Open Mobile Platform
- References: <20230214074925.228106-1-alexghiti@rivosinc.com> <20230214074925.228106-11-alexghiti@rivosinc.com> <017f0b40-8021-8b3b-24d2-c70661b6b292@omp.ru> <f3db61bb-5c89-2724-769f-9d606f587f92@xen0n.name>
- User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1
On 2/14/23 11:59 AM, WANG Xuerui wrote:
[...]
>>> From: Palmer Dabbelt <palmer@xxxxxxxxxxxx>
>>>
>>> As far as I can tell this is not used by userspace and thus should not
>>> be part of the user-visible API.
>>>
>>> Signed-off-by: Palmer Dabbelt <palmer@xxxxxxxxxxxx>
>>> ---
>>> arch/sparc/include/asm/setup.h | 6 +++++-
>>> arch/sparc/include/uapi/asm/setup.h | 7 -------
>>> 2 files changed, 5 insertions(+), 8 deletions(-)
>>>
>>> diff --git a/arch/sparc/include/asm/setup.h b/arch/sparc/include/asm/setup.h
>>> index 72205684e51e..d1384ed92547 100644
>>> --- a/arch/sparc/include/asm/setup.h
>>> +++ b/arch/sparc/include/asm/setup.h
>>> @@ -7,7 +7,11 @@
>>> #include <linux/interrupt.h>
>>> -#include <uapi/asm/setup.h>
>>> +#if defined(__sparc__) && defined(__arch64__)
>>
>> Mhm, I don't think these two can be #define'd simulaneously...
>
> I believe it's just a SPARC-ism [1] [2] that may look strange and be easily confused for __aarch64__ (notice the extra 'a')...
Yeah, sorry, I did confuse it with AArgh64. :-)
[...]
MNR, Sergey
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]