Re: [PATCH v2 10/24] mips/cpu: Make sure play_dead() doesn't return

Philippe Mathieu-Daudé <philmd@xxxxxxxxxx> · Tue, 14 Feb 2023 08:50:33 +0100

On 14/2/23 08:05, Josh Poimboeuf wrote:

play_dead() doesn't return.  Make that more explicit with a BUG().

BUG() is preferable to unreachable() because BUG() is a more explicit
failure mode and avoids undefined behavior like falling off the edge of
the function into whatever code happens to be next.

Acked-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
Signed-off-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
---
  arch/mips/kernel/smp-bmips.c | 2 ++
  arch/mips/loongson64/smp.c   | 1 +
  2 files changed, 3 insertions(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>