Re: [PATCH mm-unstable v1 04/26] arm/mm: support __HAVE_ARCH_PTE_SWP_EXCLUSIVE
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: David Hildenbrand <david@xxxxxxxxxx>
- Subject: Re: [PATCH mm-unstable v1 04/26] arm/mm: support __HAVE_ARCH_PTE_SWP_EXCLUSIVE
- From: Mark Brown <broonie@xxxxxxxxxx>
- Date: Wed, 8 Feb 2023 16:39:44 +0000
- Cc: linux-kernel@xxxxxxxxxxxxxxx, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Hugh Dickins <hughd@xxxxxxxxxx>, John Hubbard <jhubbard@xxxxxxxxxx>, Jason Gunthorpe <jgg@xxxxxxxxxx>, Mike Rapoport <rppt@xxxxxxxxxxxxx>, Yang Shi <shy828301@xxxxxxxxx>, Vlastimil Babka <vbabka@xxxxxxx>, Nadav Amit <namit@xxxxxxxxxx>, Andrea Arcangeli <aarcange@xxxxxxxxxx>, Peter Xu <peterx@xxxxxxxxxx>, linux-mm@xxxxxxxxx, x86@xxxxxxxxxx, linux-alpha@xxxxxxxxxxxxxxx, linux-snps-arc@xxxxxxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-csky@xxxxxxxxxxxxxxx, linux-hexagon@xxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, loongarch@xxxxxxxxxxxxxxx, linux-m68k@xxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, openrisc@xxxxxxxxxxxxxxxxxxxx, linux-parisc@xxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-riscv@xxxxxxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linux-sh@xxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, linux-um@xxxxxxxxxxxxxxxxxxx, linux-xtensa@xxxxxxxxxxxxxxxx, Russell King <linux@xxxxxxxxxxxxxxx>
- In-reply-to: <39fd91e3-c93b-23c6-afc6-cbe473bb0ca9@redhat.com>
- References: <20230113171026.582290-1-david@redhat.com> <20230113171026.582290-5-david@redhat.com> <Y+GcDFMNHw2cdDN1@sirena.org.uk> <39fd91e3-c93b-23c6-afc6-cbe473bb0ca9@redhat.com>
On Wed, Feb 08, 2023 at 03:12:06PM +0100, David Hildenbrand wrote:
> On 07.02.23 01:32, Mark Brown wrote:
> > Today's -next (and at least back to Friday, older logs are unclear - I
> > only noticed -next issues today) fails to NFS boot on an AT91SAM9G20-EK
> > (an old ARMv5 platform) with multi_v5_defconfig, a bisect appears to
> > point to this patch (20aae9eff5acd8f5 in today's -next) as the culprit.
> It's been in -next for quite a while, thanks for the report!
Yeah, there's been some other things obscuring the issue.
> Could you give the following a test?
>
>
> From 8c4bdbd9862f85782d5919d044c172b584063e83 Mon Sep 17 00:00:00 2001
> From: David Hildenbrand <david@xxxxxxxxxx>
> Date: Wed, 8 Feb 2023 15:08:01 +0100
> Subject: [PATCH] arm/mm: Fix swp type masking in __swp_entry()
>
> We're masking with the number of type bits instead of the type mask, which
> is obviously wrong.
Tested-by: Mark Brown <broonie@xxxxxxxxxx>
but note that I had to manually apply it, though it's pretty trivial so
I probably applied the right thing.
Attachment:
signature.asc
Description: PGP signature
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]