[RFC PATCH 19/32] ACPI: Warn when the present bit changes but the feature is not enabled
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: linux-pm@xxxxxxxxxxxxxxx, loongarch@xxxxxxxxxxxxxxx, kvmarm@xxxxxxxxxxxxxxx, kvm@xxxxxxxxxxxxxxx, linux-acpi@xxxxxxxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, x86@xxxxxxxxxx
- Subject: [RFC PATCH 19/32] ACPI: Warn when the present bit changes but the feature is not enabled
- From: James Morse <james.morse@xxxxxxx>
- Date: Fri, 3 Feb 2023 13:50:30 +0000
- Cc: Marc Zyngier <maz@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Lorenzo Pieralisi <lpieralisi@xxxxxxxxxx>, Mark Rutland <mark.rutland@xxxxxxx>, Sudeep Holla <sudeep.holla@xxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, H Peter Anvin <hpa@xxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Will Deacon <will@xxxxxxxxxx>, Catalin Marinas <catalin.marinas@xxxxxxx>, Huacai Chen <chenhuacai@xxxxxxxxxx>, James Morse <james.morse@xxxxxxx>, Suzuki K Poulose <suzuki.poulose@xxxxxxx>, Oliver Upton <oliver.upton@xxxxxxxxx>, Len Brown <lenb@xxxxxxxxxx>, Rafael Wysocki <rafael@xxxxxxxxxx>, WANG Xuerui <kernel@xxxxxxxxxx>, Salil Mehta <salil.mehta@xxxxxxxxxx>, Russell King <linux@xxxxxxxxxxxxxxx>, Jean-Philippe Brucker <jean-philippe@xxxxxxxxxx>
- In-reply-to: <20230203135043.409192-1-james.morse@arm.com>
- References: <20230203135043.409192-1-james.morse@arm.com>
ACPI firmware can trigger the events to add and remove CPUs, but the
OS may not support this.
Print a warning when this happens.
This gives early warning on arm64 systems that don't support
CONFIG_ACPI_HOTPLUG_PRESENT_CPU, as making CPUs not present has
side effects for other parts of the system.
Signed-off-by: James Morse <james.morse@xxxxxxx>
---
drivers/acpi/acpi_processor.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/acpi_processor.c b/drivers/acpi/acpi_processor.c
index e6419b06cb37..572a12672c0e 100644
--- a/drivers/acpi/acpi_processor.c
+++ b/drivers/acpi/acpi_processor.c
@@ -155,8 +155,10 @@ static int acpi_processor_make_present(struct acpi_processor *pr)
acpi_status status;
int ret;
- if (!IS_ENABLED(CONFIG_ACPI_HOTPLUG_PRESENT_CPU))
+ if (!IS_ENABLED(CONFIG_ACPI_HOTPLUG_PRESENT_CPU)) {
+ pr_err_once("Changing CPU present bit is not supported\n");
return -ENODEV;
+ }
if (invalid_phys_cpuid(pr->phys_id))
return -ENODEV;
@@ -414,8 +416,10 @@ static void acpi_processor_make_not_present(struct acpi_device *device)
{
struct acpi_processor *pr;
- if (!IS_ENABLED(CONFIG_ACPI_HOTPLUG_PRESENT_CPU))
+ if (!IS_ENABLED(CONFIG_ACPI_HOTPLUG_PRESENT_CPU)) {
+ pr_err_once("Changing CPU present bit is not supported");
return;
+ }
pr = acpi_driver_data(device);
if (pr->id >= nr_cpu_ids)
--
2.30.2
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]