[RFC PATCH 13/32] ACPI: processor: Register all CPUs from acpi_processor_get_info()
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: linux-pm@xxxxxxxxxxxxxxx, loongarch@xxxxxxxxxxxxxxx, kvmarm@xxxxxxxxxxxxxxx, kvm@xxxxxxxxxxxxxxx, linux-acpi@xxxxxxxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, x86@xxxxxxxxxx
- Subject: [RFC PATCH 13/32] ACPI: processor: Register all CPUs from acpi_processor_get_info()
- From: James Morse <james.morse@xxxxxxx>
- Date: Fri, 3 Feb 2023 13:50:24 +0000
- Cc: Marc Zyngier <maz@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Lorenzo Pieralisi <lpieralisi@xxxxxxxxxx>, Mark Rutland <mark.rutland@xxxxxxx>, Sudeep Holla <sudeep.holla@xxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, H Peter Anvin <hpa@xxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Will Deacon <will@xxxxxxxxxx>, Catalin Marinas <catalin.marinas@xxxxxxx>, Huacai Chen <chenhuacai@xxxxxxxxxx>, James Morse <james.morse@xxxxxxx>, Suzuki K Poulose <suzuki.poulose@xxxxxxx>, Oliver Upton <oliver.upton@xxxxxxxxx>, Len Brown <lenb@xxxxxxxxxx>, Rafael Wysocki <rafael@xxxxxxxxxx>, WANG Xuerui <kernel@xxxxxxxxxx>, Salil Mehta <salil.mehta@xxxxxxxxxx>, Russell King <linux@xxxxxxxxxxxxxxx>, Jean-Philippe Brucker <jean-philippe@xxxxxxxxxx>
- In-reply-to: <20230203135043.409192-1-james.morse@arm.com>
- References: <20230203135043.409192-1-james.morse@arm.com>
To allow ACPI to skip the call to arch_register_cpu() when the _STA
value indicates the CPU can't be brought online right now, move the
arch_register_cpu() call into acpi_processor_get_info().
Systems can still be booted with 'acpi=off', or in the case of arm64,
not include an ACPI description at all. For these, the CPUs are
registered by cpu_dev_register_generic().
This moves the CPU register logic back to a subsys_initcall(),
while the memory nodes will have been registered earlier.
Signed-off-by: James Morse <james.morse@xxxxxxx>
---
drivers/acpi/acpi_processor.c | 6 ++++++
drivers/base/cpu.c | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/acpi/acpi_processor.c b/drivers/acpi/acpi_processor.c
index 967837b60453..a93a6c4115c4 100644
--- a/drivers/acpi/acpi_processor.c
+++ b/drivers/acpi/acpi_processor.c
@@ -272,6 +272,12 @@ static int acpi_processor_get_info(struct acpi_device *device)
pr->id = 0;
}
+ if (!invalid_logical_cpuid(pr->id) && cpu_present(pr->id)) {
+ int ret = arch_register_cpu(pr->id);
+ if (ret)
+ return ret;
+ }
+
/*
* Extra Processor objects may be enumerated on MP systems with
* less than the max # of CPUs. They should be ignored _iff
diff --git a/drivers/base/cpu.c b/drivers/base/cpu.c
index 178936533d87..0ba646022a5e 100644
--- a/drivers/base/cpu.c
+++ b/drivers/base/cpu.c
@@ -504,7 +504,7 @@ static void __init cpu_dev_register_generic(void)
{
int i;
- if (!IS_ENABLED(CONFIG_GENERIC_CPU_DEVICES))
+ if (!IS_ENABLED(CONFIG_GENERIC_CPU_DEVICES) || !acpi_disabled)
return;
for_each_present_cpu(i) {
--
2.30.2
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]