Re: [PATCH v4] hugetlb: simplify hugetlb handling in follow_page_mask
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Peter Xu <peterx@xxxxxxxxxx>
- Subject: Re: [PATCH v4] hugetlb: simplify hugetlb handling in follow_page_mask
- From: Mike Kravetz <mike.kravetz@xxxxxxxxxx>
- Date: Sun, 30 Oct 2022 16:00:07 -0700
- Cc: linux-mm@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx>, Christophe Leroy <christophe.leroy@xxxxxxxxxx>, David Hildenbrand <david@xxxxxxxxxx>, "Aneesh Kumar K . V" <aneesh.kumar@xxxxxxxxxxxxx>, Naoya Horiguchi <naoya.horiguchi@xxxxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Muchun Song <songmuchun@xxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
- In-reply-to: <Y17UPk9CBjPumcz6@x1n>
- References: <20221028181108.119432-1-mike.kravetz@oracle.com> <Y17UPk9CBjPumcz6@x1n>
On 10/30/22 15:45, Peter Xu wrote:
> On Fri, Oct 28, 2022 at 11:11:08AM -0700, Mike Kravetz wrote:
> > + } else {
> > + if (is_hugetlb_entry_migration(entry)) {
> > + spin_unlock(ptl);
> > + hugetlb_vma_unlock_read(vma);
>
> Just noticed it when pulled the last mm-unstable: this line seems to be a
> left-over of v3, while not needed now?
>
> > + __migration_entry_wait_huge(pte, ptl);
> > + goto retry;
> > + }
Thanks Peter!
Sent v5 with the that line removed.
--
Mike Kravetz
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]