Re: [RFC PATCH] Remove Intel compiler support
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Miguel Ojeda <miguel.ojeda.sandonis@xxxxxxxxx>
- Subject: Re: [RFC PATCH] Remove Intel compiler support
- From: Masahiro Yamada <masahiroy@xxxxxxxxxx>
- Date: Wed, 12 Oct 2022 02:02:33 +0900
- Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, x86@xxxxxxxxxx, "H . Peter Anvin" <hpa@xxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, linux-ia64@xxxxxxxxxxxxxxx, Nick Desaulniers <ndesaulniers@xxxxxxxxxx>, Miguel Ojeda <ojeda@xxxxxxxxxx>, Len Brown <lenb@xxxxxxxxxx>, Nathan Chancellor <nathan@xxxxxxxxxx>, Nick Terrell <terrelln@xxxxxx>, "Rafael J. Wysocki" <rafael.j.wysocki@xxxxxxxxx>, Robert Moore <robert.moore@xxxxxxxxx>, Tom Rix <trix@xxxxxxxxxx>, devel@xxxxxxxxxx, linux-acpi@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, llvm@xxxxxxxxxxxxxxx
- In-reply-to: <CAK7LNASP74qJ5fjjcVYcw4CyZ1psPnnyzLHsUu0b+MxLq-W1eQ@mail.gmail.com>
- References: <20221011031843.960217-1-masahiroy@kernel.org> <CANiq72k9wAVCbHKVZFE=E3xv+2ZamUMsJ=uV43NxsSUQ4wXGdw@mail.gmail.com> <CAK7LNASP74qJ5fjjcVYcw4CyZ1psPnnyzLHsUu0b+MxLq-W1eQ@mail.gmail.com>
On Wed, Oct 12, 2022 at 1:52 AM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
>
> On Tue, Oct 11, 2022 at 8:55 PM Miguel Ojeda
> <miguel.ojeda.sandonis@xxxxxxxxx> wrote:
> >
> > On Tue, Oct 11, 2022 at 5:19 AM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
> > >
> > > include/linux/compiler-intel.h | 34 -----
> > > include/linux/compiler_types.h | 2 -
> >
> > You can also remove a few lines from `compiler_attributes.h`:
> >
> > * Optional: not supported by icc
> >
> > Thanks for this!
> >
> > Cheers,
> > Miguel
>
>
>
> Thanks.
>
>
> Maybe, we can drop #if ... #else ... #endif
> around __assume_aligned(a, ...), but I will leave it to you.
>
>
> I will just drop the comment lines for now.
> (Then, you will clean up compiler_attributes.h in the next cycle)
> Is this your expectation for v2 ?
Taking a look at the code, there is only one redundant #if.
So, I will clean up __assume_aligned() in v2.
--
Best Regards
Masahiro Yamada
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]