On Sun, Sep 11, 2022, at 3:26 AM, Randy Dunlap wrote: > cxl_pmem.ko uses memory_add_physaddr_to_nid() but ia64 does not export it, > so this causes a build error: > > ERROR: modpost: "memory_add_physaddr_to_nid" [drivers/cxl/cxl_pmem.ko] > undefined! > > Fix this by exporting that function. > > Fixes: 8c2676a5870a ("hot-add-mem x86_64: memory_add_physaddr_to_nid > node fixup") > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > Cc: Dan Williams <dan.j.williams@xxxxxxxxx> > Cc: Ben Widawsky <bwidawsk@xxxxxxxxxx> > Cc: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > Cc: linux-ia64@xxxxxxxxxxxxxxx > Cc: Arnd Bergmann <arnd@xxxxxxxx> > Cc: Keith Mannthey <kmannth@xxxxxxxxxx> > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > --- > Arnd, can you take this in your one-off fixes arch tree, or would > you prefer for Andrew to take it? I've applied it to the asm-generic tree for 6.1 now, as I don't expect any other bugfixes for 6.0 to go through that tree. It's clearly a bugfix, but since the original commit you cite was from 2006, I assume it can wait a little longer. Arnd