Re: [PATCH v4] mm: Avoid unnecessary page fault retires on shared memory types
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Peter Xu <peterx@xxxxxxxxxx>
- Subject: Re: [PATCH v4] mm: Avoid unnecessary page fault retires on shared memory types
- From: Catalin Marinas <catalin.marinas@xxxxxxx>
- Date: Mon, 30 May 2022 14:31:52 +0100
- Cc: linux-kernel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, Will Deacon <will@xxxxxxxxxx>, Matt Turner <mattst88@xxxxxxxxx>, linux-s390@xxxxxxxxxxxxxxx, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Brian Cain <bcain@xxxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, linux-alpha@xxxxxxxxxxxxxxx, Alistair Popple <apopple@xxxxxxxxxx>, Jonas Bonn <jonas@xxxxxxxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Stefan Kristiansson <stefan.kristiansson@xxxxxxxxxxxxx>, linux-snps-arc@xxxxxxxxxxxxxxxxxxx, Vineet Gupta <vgupta@xxxxxxxxxx>, Vasily Gorbik <gor@xxxxxxxxxxxxx>, Vlastimil Babka <vbabka@xxxxxxx>, Ivan Kokshaysky <ink@xxxxxxxxxxxxxxxxxxxx>, Rich Felker <dalias@xxxxxxxx>, sparclinux@xxxxxxxxxxxxxxx, Russell King <linux@xxxxxxxxxxxxxxx>, David Hildenbrand <david@xxxxxxxxxx>, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>, Nicholas Piggin <npiggin@xxxxxxxxx>, "James E . J . Bottomley" <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>, linux-xtensa@xxxxxxxxxxxxxxxx, linux-sh@xxxxxxxxxxxxxxx, Paul Walmsley <paul.walmsley@xxxxxxxxxx>, linux-m68k@xxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, Richard Henderson <rth@xxxxxxxxxxxxxxx>, Guo Ren <guoren@xxxxxxxxxx>, linux-parisc@xxxxxxxxxxxxxxx, Andrea Arcangeli <aarcange@xxxxxxxxxx>, Helge Deller <deller@xxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Albert Ou <aou@xxxxxxxxxxxxxxxxx>, linux-um@xxxxxxxxxxxxxxxxxxx, "H . Peter Anvin" <hpa@xxxxxxxxx>, Janosch Frank <frankja@xxxxxxxxxxxxx>, Sven Schnelle <svens@xxxxxxxxxxxxx>, Anton Ivanov <anton.ivanov@xxxxxxxxxxxxxxxxxx>, openrisc@xxxxxxxxxxxxxxxxxxxx, Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>, linux-hexagon@xxxxxxxxxxxxxxx, Andy Lutomirski <luto@xxxxxxxxxx>, Stafford Horne <shorne@xxxxxxxxx>, linux-csky@xxxxxxxxxxxxxxx, Heiko Carstens <hca@xxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, linux-mips@xxxxxxxxxxxxxxx, Paul Mackerras <paulus@xxxxxxxxx>, Alexander Gordeev <agordeev@xxxxxxxxxxxxx>, Dinh Nguyen <dinguyen@xxxxxxxxxx>, Palmer Dabbelt <palmer@xxxxxxxxxxx>, "David S . Miller" <davem@xxxxxxxxxxxxx>, Johannes Weiner <hannes@xxxxxxxxxxx>, Hugh Dickins <hughd@xxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, linux-riscv@xxxxxxxxxxxxxxxxxxx, Max Filippov <jcmvbkbc@xxxxxxxxx>, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>, Christian Borntraeger <borntraeger@xxxxxxxxxxxxx>, Johannes Berg <johannes@xxxxxxxxxxxxxxxx>, Chris Zankel <chris@xxxxxxxxxx>, Michal Simek <monstr@xxxxxxxxx>, x86@xxxxxxxxxx, Yoshinori Sato <ysato@xxxxxxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, Richard Weinberger <richard@xxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>
- In-reply-to: <20220527193936.30678-1-peterx@redhat.com>
- References: <20220527193936.30678-1-peterx@redhat.com>
On Fri, May 27, 2022 at 03:39:36PM -0400, Peter Xu wrote:
> diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c
> index 77341b160aca..e401d416bbd6 100644
> --- a/arch/arm64/mm/fault.c
> +++ b/arch/arm64/mm/fault.c
> @@ -607,6 +607,10 @@ static int __kprobes do_page_fault(unsigned long far, unsigned int esr,
> return 0;
> }
>
> + /* The fault is fully completed (including releasing mmap lock) */
> + if (fault & VM_FAULT_COMPLETED)
> + return 0;
> +
> if (fault & VM_FAULT_RETRY) {
> mm_flags |= FAULT_FLAG_TRIED;
> goto retry;
For arm64:
Acked-by: Catalin Marinas <catalin.marinas@xxxxxxx>
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]