Re: [PATCH 07/16] signal: Wake up the designated parent

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>
Subject: Re: [PATCH 07/16] signal: Wake up the designated parent
From: Oleg Nesterov <oleg@xxxxxxxxxx>
Date: Tue, 24 May 2022 18:28:09 +0200
Cc: linux-kernel@xxxxxxxxxxxxxxx, rjw@xxxxxxxxxxxxx, mingo@xxxxxxxxxx, vincent.guittot@xxxxxxxxxx, dietmar.eggemann@xxxxxxx, rostedt@xxxxxxxxxxx, mgorman@xxxxxxx, bigeasy@xxxxxxxxxxxxx, Will Deacon <will@xxxxxxxxxx>, tj@xxxxxxxxxx, linux-pm@xxxxxxxxxxxxxxx, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Richard Weinberger <richard@xxxxxx>, Anton Ivanov <anton.ivanov@xxxxxxxxxxxxxxxxxx>, Johannes Berg <johannes@xxxxxxxxxxxxxxxx>, linux-um@xxxxxxxxxxxxxxxxxxx, Chris Zankel <chris@xxxxxxxxxx>, Max Filippov <jcmvbkbc@xxxxxxxxx>, linux-xtensa@xxxxxxxxxxxxxxxx, Kees Cook <keescook@xxxxxxxxxxxx>, Jann Horn <jannh@xxxxxxxxxx>, linux-ia64@xxxxxxxxxxxxxxx, Robert OCallahan <roc@xxxxxxxxx>, Kyle Huey <khuey@xxxxxxxxx>, Richard Henderson <rth@xxxxxxxxxxxxxxx>, Ivan Kokshaysky <ink@xxxxxxxxxxxxxxxxxxxx>, Matt Turner <mattst88@xxxxxxxxx>, Jason Wessel <jason.wessel@xxxxxxxxxxxxx>, Daniel Thompson <daniel.thompson@xxxxxxxxxx>, Douglas Anderson <dianders@xxxxxxxxxxxx>, Douglas Miller <dougmill@xxxxxxxxxxxxxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>, Paul Mackerras <paulus@xxxxxxxxx>
In-reply-to: <20220524132553.GD14347@redhat.com>
References: <871qwq5ucx.fsf_-_@email.froward.int.ebiederm.org> <20220518225355.784371-7-ebiederm@xmission.com> <20220524132553.GD14347@redhat.com>
User-agent: Mutt/1.5.24 (2015-08-30)

On 05/24, Oleg Nesterov wrote:
>
> I fail to understand this patch...
>
> On 05/18, Eric W. Biederman wrote:
> >
> > Today if a process is ptraced only the ptracer will ever be woken up in
> > wait
>
> and why is this wrong?
>
> > Fixes: 75b95953a569 ("job control: Add @for_ptrace to do_notify_parent_cldstop()")
>
> how does this change fix 75b95953a569?

OK, I guess you mean the 2nd do_notify_parent_cldstop() in ptrace_stop(),
the problematic case is current->ptrace == T. Right?

I dislike this patch anyway, but let me think more about it.

Oleg.

Follow-Ups:
- Re: [PATCH 07/16] signal: Wake up the designated parent
  - From: Oleg Nesterov

References:
- [PATCH 00/16] ptrace: cleanups and calling do_cldstop with only siglock
  - From: Eric W. Biederman
- [PATCH 07/16] signal: Wake up the designated parent
  - From: Eric W. Biederman
- Re: [PATCH 07/16] signal: Wake up the designated parent
  - From: Oleg Nesterov

Prev by Date: Re: [PATCH 08/16] ptrace: Only populate last_siginfo from ptrace
Next by Date: Re: [PATCH v8 07/27] kernel/reboot: Add kernel_can_power_off()
Previous by thread: Re: [PATCH 07/16] signal: Wake up the designated parent
Next by thread: Re: [PATCH 07/16] signal: Wake up the designated parent
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel] [Sparc Linux] [DCCP] [Linux ARM] [Yosemite News] [Linux SCSI] [Linux x86_64] [Linux for Ham Radio]