Re: [PATCH 09/22] gpio-winbond: Use C99 initializers
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Benjamin Stürz <benni@xxxxxxxxxx>
- Subject: Re: [PATCH 09/22] gpio-winbond: Use C99 initializers
- From: Bartosz Golaszewski <brgl@xxxxxxxx>
- Date: Tue, 29 Mar 2022 14:30:40 +0200
- Cc: Andrew Lunn <andrew@xxxxxxx>, Sebastian Hesselbarth <sebastian.hesselbarth@xxxxxxxxx>, Gregory Clement <gregory.clement@xxxxxxxxxxx>, Russell King <linux@xxxxxxxxxxxxxxx>, linux@xxxxxxxxxxxx, Krzysztof Kozlowski <krzk@xxxxxxxxxx>, alim.akhtar@xxxxxxxxxxx, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, mingo@xxxxxxxxxx, Borislav Petkov <bp@xxxxxxxxx>, dave.hansen@xxxxxxxxxxxxxxx, hpa@xxxxxxxxx, robert.moore@xxxxxxxxx, "Rafael J . Wysocki" <rafael.j.wysocki@xxxxxxxxx>, lenb@xxxxxxxxxx, 3chas3@xxxxxxxxx, laforge@xxxxxxxxxxxx, Arnd Bergmann <arnd@xxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>, Tony Luck <tony.luck@xxxxxxxxx>, James Morse <james.morse@xxxxxxx>, Robert Richter <rric@xxxxxxxxxx>, Linus Walleij <linus.walleij@xxxxxxxxxx>, mike.marciniszyn@xxxxxxxxxxxxxxxxxxxx, dennis.dalessandro@xxxxxxxxxxxxxxxxxxxx, jgg@xxxxxxxx, pali@xxxxxxxxxx, Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>, isdn@xxxxxxxxxxxxxx, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>, fbarrat@xxxxxxxxxxxxx, ajd@xxxxxxxxxxxxx, "David S . Miller" <davem@xxxxxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, nico@xxxxxxxxxxx, loic.poulain@xxxxxxxxxx, kvalo@xxxxxxxxxx, pkshih@xxxxxxxxxxx, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, Linux ARM <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, linux-samsung-soc@xxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, ACPI Devel Maling List <linux-acpi@xxxxxxxxxxxxxxx>, devel@xxxxxxxxxx, linux-atm-general@xxxxxxxxxxxxxxxxxxxxx, netdev <netdev@xxxxxxxxxxxxxxx>, linux-edac@xxxxxxxxxxxxxxx, "open list:GPIO SUBSYSTEM" <linux-gpio@xxxxxxxxxxxxxxx>, linux-rdma@xxxxxxxxxxxxxxx, Linux Input <linux-input@xxxxxxxxxxxxxxx>, linuxppc-dev@xxxxxxxxxxxxxxxx, Linux Media Mailing List <linux-media@xxxxxxxxxxxxxxx>, wcn36xx@xxxxxxxxxxxxxxxxxxx, linux-wireless@xxxxxxxxxxxxxxx, linux-pci@xxxxxxxxxxxxxxx
- In-reply-to: <20220326165909.506926-9-benni@stuerz.xyz>
- References: <20220326165909.506926-1-benni@stuerz.xyz> <20220326165909.506926-9-benni@stuerz.xyz>
On Sat, Mar 26, 2022 at 6:00 PM Benjamin Stürz <benni@xxxxxxxxxx> wrote:
>
> This replaces comments with C99's designated
> initializers because the kernel supports them now.
>
> Signed-off-by: Benjamin Stürz <benni@xxxxxxxxxx>
> ---
> drivers/gpio/gpio-winbond.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpio/gpio-winbond.c b/drivers/gpio/gpio-winbond.c
> index 7f8f5b02e31d..0b637fdb407c 100644
> --- a/drivers/gpio/gpio-winbond.c
> +++ b/drivers/gpio/gpio-winbond.c
> @@ -249,7 +249,7 @@ struct winbond_gpio_info {
> };
>
> static const struct winbond_gpio_info winbond_gpio_infos[6] = {
> - { /* 0 */
> + [0] = {
> .dev = WB_SIO_DEV_GPIO12,
> .enablereg = WB_SIO_GPIO12_REG_ENABLE,
> .enablebit = WB_SIO_GPIO12_ENABLE_1,
> @@ -266,7 +266,7 @@ static const struct winbond_gpio_info winbond_gpio_infos[6] = {
> .warnonly = true
> }
> },
> - { /* 1 */
> + [1] = {
> .dev = WB_SIO_DEV_GPIO12,
> .enablereg = WB_SIO_GPIO12_REG_ENABLE,
> .enablebit = WB_SIO_GPIO12_ENABLE_2,
> @@ -277,7 +277,7 @@ static const struct winbond_gpio_info winbond_gpio_infos[6] = {
> .datareg = WB_SIO_GPIO12_REG_DATA2
> /* special conflict handling so doesn't use conflict data */
> },
> - { /* 2 */
> + [2] = {
> .dev = WB_SIO_DEV_GPIO34,
> .enablereg = WB_SIO_GPIO34_REG_ENABLE,
> .enablebit = WB_SIO_GPIO34_ENABLE_3,
> @@ -294,7 +294,7 @@ static const struct winbond_gpio_info winbond_gpio_infos[6] = {
> .warnonly = true
> }
> },
> - { /* 3 */
> + [3] = {
> .dev = WB_SIO_DEV_GPIO34,
> .enablereg = WB_SIO_GPIO34_REG_ENABLE,
> .enablebit = WB_SIO_GPIO34_ENABLE_4,
> @@ -311,7 +311,7 @@ static const struct winbond_gpio_info winbond_gpio_infos[6] = {
> .warnonly = true
> }
> },
> - { /* 4 */
> + [4] = {
> .dev = WB_SIO_DEV_WDGPIO56,
> .enablereg = WB_SIO_WDGPIO56_REG_ENABLE,
> .enablebit = WB_SIO_WDGPIO56_ENABLE_5,
> @@ -328,7 +328,7 @@ static const struct winbond_gpio_info winbond_gpio_infos[6] = {
> .warnonly = true
> }
> },
> - { /* 5 */
> + [5] = {
> .dev = WB_SIO_DEV_WDGPIO56,
> .enablereg = WB_SIO_WDGPIO56_REG_ENABLE,
> .enablebit = WB_SIO_WDGPIO56_ENABLE_6,
> --
> 2.35.1
>
Acked-by: Bartosz Golaszewski <brgl@xxxxxxxx>
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]