Re: [PATCH 13/15] swiotlb: merge swiotlb-xen initialization into swiotlb
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
- Subject: Re: [PATCH 13/15] swiotlb: merge swiotlb-xen initialization into swiotlb
- From: Christoph Hellwig <hch@xxxxxx>
- Date: Tue, 15 Mar 2022 07:48:26 +0100
- Cc: Christoph Hellwig <hch@xxxxxx>, iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx, x86@xxxxxxxxxx, Anshuman Khandual <anshuman.khandual@xxxxxxx>, Tom Lendacky <thomas.lendacky@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Joerg Roedel <joro@xxxxxxxxxx>, David Woodhouse <dwmw2@xxxxxxxxxxxxx>, Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>, Robin Murphy <robin.murphy@xxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-riscv@xxxxxxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linux-hyperv@xxxxxxxxxxxxxxx, tboot-devel@xxxxxxxxxxxxxxxxxxxxx, linux-pci@xxxxxxxxxxxxxxx
- In-reply-to: <6a43380c-b873-3f8e-5d5b-4a066ee57ac2@oracle.com>
- References: <20220314073129.1862284-1-hch@lst.de> <20220314073129.1862284-14-hch@lst.de> <6a43380c-b873-3f8e-5d5b-4a066ee57ac2@oracle.com>
- User-agent: Mutt/1.5.17 (2007-11-01)
On Mon, Mar 14, 2022 at 07:07:44PM -0400, Boris Ostrovsky wrote:
>> + swiotlb_init_remap(true, x86_swiotlb_flags, xen_swiotlb_fixup);
>
>
> I think we need to have SWIOTLB_ANY set in x86_swiotlb_flags here.
Yes.
> Notice that we don't do remap() after final update to nslabs. We should.
Indeed. I've pushed the fixed patches to the git tree and attached
the patches 12, 13 and 14 in case that is easier:
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]
