Re: [PATCH v2 15/18] sparc64: remove CONFIG_SET_FS support
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Arnd Bergmann <arnd@xxxxxxxxxx>
- Subject: Re: [PATCH v2 15/18] sparc64: remove CONFIG_SET_FS support
- From: Sam Ravnborg <sam@xxxxxxxxxxxx>
- Date: Wed, 16 Feb 2022 19:41:09 +0100
- Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, linux-arch@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, linux-api@xxxxxxxxxxxxxxx, arnd@xxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, viro@xxxxxxxxxxxxxxxxxx, linux@xxxxxxxxxxxxxxx, will@xxxxxxxxxx, guoren@xxxxxxxxxx, bcain@xxxxxxxxxxxxxx, geert@xxxxxxxxxxxxxx, monstr@xxxxxxxxx, tsbogend@xxxxxxxxxxxxxxxx, nickhu@xxxxxxxxxxxxx, green.hu@xxxxxxxxx, dinguyen@xxxxxxxxxx, shorne@xxxxxxxxx, deller@xxxxxx, mpe@xxxxxxxxxxxxxx, peterz@xxxxxxxxxxxxx, mingo@xxxxxxxxxx, mark.rutland@xxxxxxx, hca@xxxxxxxxxxxxx, dalias@xxxxxxxx, davem@xxxxxxxxxxxxx, richard@xxxxxx, x86@xxxxxxxxxx, jcmvbkbc@xxxxxxxxx, ebiederm@xxxxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, ardb@xxxxxxxxxx, linux-alpha@xxxxxxxxxxxxxxx, linux-snps-arc@xxxxxxxxxxxxxxxxxxx, linux-csky@xxxxxxxxxxxxxxx, linux-hexagon@xxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-m68k@xxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, openrisc@xxxxxxxxxxxxxxxxxxxx, linux-parisc@xxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-riscv@xxxxxxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linux-sh@xxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, linux-um@xxxxxxxxxxxxxxxxxxx, linux-xtensa@xxxxxxxxxxxxxxxx
- In-reply-to: <Yg1D08+olCSGmnYU@ravnborg.org>
- References: <20220216131332.1489939-1-arnd@kernel.org> <20220216131332.1489939-16-arnd@kernel.org> <Yg1D08+olCSGmnYU@ravnborg.org>
Hi Arnd,
On Wed, Feb 16, 2022 at 07:34:59PM +0100, Sam Ravnborg wrote:
> Hi Arnd.
>
> On Wed, Feb 16, 2022 at 02:13:29PM +0100, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@xxxxxxxx>
> >
> > sparc64 uses address space identifiers to differentiate between kernel
> > and user space, using ASI_P for kernel threads but ASI_AIUS for normal
> > user space, with the option of changing between them.
> >
> > As nothing really changes the ASI any more, just hardcode ASI_AIUS
> > everywhere. Kernel threads are not allowed to access __user pointers
> > anyway.
> >
> > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> > ---
> > arch/sparc/include/asm/processor_64.h | 4 ----
> > arch/sparc/include/asm/switch_to_64.h | 4 +---
> > arch/sparc/include/asm/thread_info_64.h | 4 +---
> > arch/sparc/include/asm/uaccess_64.h | 20 +-------------------
> > arch/sparc/kernel/process_64.c | 12 ------------
> > arch/sparc/kernel/traps_64.c | 2 --
> > arch/sparc/lib/NGmemcpy.S | 3 +--
> > arch/sparc/mm/init_64.c | 7 ++++---
> > 8 files changed, 8 insertions(+), 48 deletions(-)
>
> I think you somehow missed the Kconfig change, and also the related
> sparc32 change which continue to have set_fs() after this patch.
I now notice the sparc32 bits are in the last patch.
To avoid breaking bisect-ability on sparc64 I think you need to merge
the sparc32 changes with this patch, unless the sparc64 changes can
coexist with CONFIG_SET_FS continue to be set.
Sam
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]