Re: [PATCH 03/14] nds32: fix access_ok() checks in get/put_user
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Arnd Bergmann <arnd@xxxxxxxxxx>
- Subject: Re: [PATCH 03/14] nds32: fix access_ok() checks in get/put_user
- From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
- Date: Mon, 14 Feb 2022 09:01:10 -0800
- Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, linux-arch@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, linux-api@xxxxxxxxxxxxxxx, arnd@xxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, mark.rutland@xxxxxxx, dalias@xxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-sh@xxxxxxxxxxxxxxx, peterz@xxxxxxxxxxxxx, jcmvbkbc@xxxxxxxxx, guoren@xxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, linux-hexagon@xxxxxxxxxxxxxxx, linux-riscv@xxxxxxxxxxxxxxxxxxx, will@xxxxxxxxxx, ardb@xxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, bcain@xxxxxxxxxxxxxx, deller@xxxxxx, x86@xxxxxxxxxx, linux@xxxxxxxxxxxxxxx, linux-csky@xxxxxxxxxxxxxxx, mingo@xxxxxxxxxx, geert@xxxxxxxxxxxxxx, linux-snps-arc@xxxxxxxxxxxxxxxxxxx, linux-xtensa@xxxxxxxxxxxxxxxx, hca@xxxxxxxxxxxxx, linux-alpha@xxxxxxxxxxxxxxx, linux-um@xxxxxxxxxxxxxxxxxxx, linux-m68k@xxxxxxxxxxxxxxx, openrisc@xxxxxxxxxxxxxxxxxxxx, green.hu@xxxxxxxxx, shorne@xxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, monstr@xxxxxxxxx, tsbogend@xxxxxxxxxxxxxxxx, linux-parisc@xxxxxxxxxxxxxxx, nickhu@xxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, stable@xxxxxxxxxxxxxxx, dinguyen@xxxxxxxxxx, ebiederm@xxxxxxxxxxxx, richard@xxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, davem@xxxxxxxxxxxxx
- In-reply-to: <20220214163452.1568807-4-arnd@kernel.org>
- References: <20220214163452.1568807-1-arnd@kernel.org> <20220214163452.1568807-4-arnd@kernel.org>
On Mon, Feb 14, 2022 at 05:34:41PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> The get_user()/put_user() functions are meant to check for
> access_ok(), while the __get_user()/__put_user() functions
> don't.
>
> This broke in 4.19 for nds32, when it gained an extraneous
> check in __get_user(), but lost the check it needs in
> __put_user().
Can we follow the lead of MIPS (which this was originally copied
from I think) and kill the pointless __get/put_user_check wrapper
that just obsfucate the code?
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]
