Le 18/10/2021 à 08:27, Nicholas Piggin a écrit :
Excerpts from Christophe Leroy's message of October 17, 2021 10:38 pm:In preparation of making func_desc_t generic, change the ELFv2 version to a struct containing 'addr' element. This allows using single helpers common to ELFv1 and ELFv2. Signed-off-by: Christophe Leroy <christophe.leroy@xxxxxxxxxx>--- arch/powerpc/kernel/module_64.c | 32 ++++++++++++++------------------ 1 file changed, 14 insertions(+), 18 deletions(-) diff --git a/arch/powerpc/kernel/module_64.c b/arch/powerpc/kernel/module_64.c index a89da0ee25e2..b687ef88c4c4 100644 --- a/arch/powerpc/kernel/module_64.c +++ b/arch/powerpc/kernel/module_64.c @@ -33,19 +33,13 @@ #ifdef PPC64_ELF_ABI_v2/* An address is simply the address of the function. */-typedef unsigned long func_desc_t; +typedef struct { + unsigned long addr; +} func_desc_t;I'm not quite following why this change is done. I guess it is so you can move this func_desc_t type into core code, but why do that? Is it just to avoid using the preprocessor?
I explained it in patch 7 but yes it probably also deserves some more explanation here as well.
That's right, it's to avoid having to spread #ifdefs everywhere.
On its own this patch looks okay. Acked-by: Nicholas Piggin <npiggin@xxxxxxxxx>
|