Re: [PATCH v2] ia64: don't do IA64_CMPXCHG_DEBUG without CONFIG_PRINTK

Randy Dunlap <rdunlap@xxxxxxxxxxxxx> · Sun, 26 Sep 2021 21:53:33 -0700

On 9/26/21 8:22 PM, Paul Gortmaker wrote:

[[PATCH v2] ia64: don't do IA64_CMPXCHG_DEBUG without CONFIG_PRINTK] On 26/09/2021 (Sun 10:12) Randy Dunlap wrote:


When CONFIG_PRINTK is not set, the CMPXCHG_BUGCHECK() macro calls
_printk(), but _printk() is a static inline function, not available
as an extern.
Since the purpose of the macro is to print the BUGCHECK info,
make this config option depend on PRINTK.

Fixes multiple occurrences of this build error:

../include/linux/printk.h:208:5: error: static declaration of '_printk' follows non-static declaration
   208 | int _printk(const char *s, ...)
       |     ^~~~~~~
In file included from ../arch/ia64/include/asm/cmpxchg.h:5,
../arch/ia64/include/uapi/asm/cmpxchg.h:146:28: note: previous declaration of '_printk' with type 'int(const char *, ...)'
   146 |                 extern int _printk(const char *fmt, ...);

Fixes: 85f8f7759e41 ("ia64: populate the cmpxchg header with appropriate code")


I don't think this fixes tag makes sense either as it was just a
straightforward code relocation.  As pointed out elsewhere, it will
probably be back even further where CONFIG_PRINTK was introduced, which
would be d59745ce3e7a (2005 vintage).  The ia64 debug option predates
git, so it isn't at fault (and you can't blame it anyway).

Honestly, realize this is just for a randconfig for ia64 where PRINTK is
disabled - something that will never be done in any of the remaining
ia64 deployments out there (if there is any).  So I'd just recommend
dropping the Fixes tag and move on.  It isn't like there is a lot of
people out there doing randconfig builds on linux-stable releases.



Yes, I like the idea of dropping the Fixes: tag also. Thanks.
Guess I'll send a v3.


--


Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Cc: linux-ia64@xxxxxxxxxxxxxxx
Cc: Petr Mladek <pmladek@xxxxxxxx>
Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Cc: Tony Luck <tony.luck@xxxxxxxxx>
Cc: Chris Down <chris@xxxxxxxxxxxxxx>
Cc: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
Cc: John Paul Adrian Glaubitz <glaubitz@xxxxxxxxxxxxxxxxxxx>
---
v2: correct the Fixes: commit info

  arch/ia64/Kconfig.debug |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20210917.orig/arch/ia64/Kconfig.debug
+++ linux-next-20210917/arch/ia64/Kconfig.debug
@@ -39,7 +39,7 @@ config DISABLE_VHPT

  

  config IA64_DEBUG_CMPXCHG

  	bool "Turn on compare-and-exchange bug checking (slow!)"
-	depends on DEBUG_KERNEL
+	depends on DEBUG_KERNEL && PRINTK
  	help
  	  Selecting this option turns on bug checking for the IA-64
  	  compare-and-exchange instructions.  This is slow!  Itaniums



--
~Randy


