Hi Randy!
On 9/26/21 08:33, Randy Dunlap wrote:
> When CONFIG_PRINTK is not set, the CMPXCHG_BUGCHECK() macro calls
> _printk(), but _printk() is a static inline function, not available
> as an extern.
> Since the purpose of the macro is to print the BUGCHECK info,
> make this config option depend on PRINTK.
>
> Fixes multiple occurrences of this build error:
>
> ../include/linux/printk.h:208:5: error: static declaration of '_printk' follows non-static declaration
> 208 | int _printk(const char *s, ...)
> | ^~~~~~~
> In file included from ../arch/ia64/include/asm/cmpxchg.h:5,
> ../arch/ia64/include/uapi/asm/cmpxchg.h:146:28: note: previous declaration of '_printk' with type 'int(const char *, ...)'
> 146 | extern int _printk(const char *fmt, ...);
>
> Fixes: 337015573718 ("printk: Userspace format indexing support")
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: linux-ia64@xxxxxxxxxxxxxxx
> Cc: Petr Mladek <pmladek@xxxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Cc: Tony Luck <tony.luck@xxxxxxxxx>
> Cc: Chris Down <chris@xxxxxxxxxxxxxx>
> ---
> arch/ia64/Kconfig.debug | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20210917.orig/arch/ia64/Kconfig.debug
> +++ linux-next-20210917/arch/ia64/Kconfig.debug
> @@ -39,7 +39,7 @@ config DISABLE_VHPT
>
> config IA64_DEBUG_CMPXCHG
> bool "Turn on compare-and-exchange bug checking (slow!)"
> - depends on DEBUG_KERNEL
> + depends on DEBUG_KERNEL && PRINTK
> help
> Selecting this option turns on bug checking for the IA-64
> compare-and-exchange instructions. This is slow! Itaniums
We currently don't have a maintainer for ia64 - although I would be willing to pick
up the job - so your patch would have to go through someone else's tree.
I can boot test the patch on my RX2660 in the mean time.
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - glaubitz@xxxxxxxxxx
`. `' Freie Universitaet Berlin - glaubitz@xxxxxxxxxxxxxxxxxxx
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
|