Re: [PATCH v3 6/9] microblaze: use generic strncpy/strnlen from_user
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Arnd Bergmann <arnd@xxxxxxxxxx>
- Subject: Re: [PATCH v3 6/9] microblaze: use generic strncpy/strnlen from_user
- From: Christoph Hellwig <hch@xxxxxx>
- Date: Thu, 22 Jul 2021 15:01:31 +0200
- Cc: linux-arch@xxxxxxxxxxxxxxx, Arnd Bergmann <arnd@xxxxxxxx>, "James E.J. Bottomley" <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Anton Ivanov <anton.ivanov@xxxxxxxxxxxxxxxxxx>, Brian Cain <bcain@xxxxxxxxxxxxxx>, Chris Zankel <chris@xxxxxxxxxx>, Christian Borntraeger <borntraeger@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, Guo Ren <guoren@xxxxxxxxxx>, Heiko Carstens <hca@xxxxxxxxxxxxx>, Helge Deller <deller@xxxxxx>, Jeff Dike <jdike@xxxxxxxxxxx>, Linus Walleij <linus.walleij@xxxxxxxxxx>, Max Filippov <jcmvbkbc@xxxxxxxxx>, Michal Simek <monstr@xxxxxxxxx>, Richard Weinberger <richard@xxxxxx>, Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>, Vasily Gorbik <gor@xxxxxxxxxxxxx>, Vineet Gupta <vgupta@xxxxxxxxxxxx>, Yoshinori Sato <ysato@xxxxxxxxxxxxx>, linux-csky@xxxxxxxxxxxxxxx, linux-hexagon@xxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, linux-parisc@xxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linux-snps-arc@xxxxxxxxxxxxxxxxxxx, linux-um@xxxxxxxxxxxxxxxxxxx, linux-xtensa@xxxxxxxxxxxxxxxx, uclinux-h8-devel@xxxxxxxxxxxxx
- In-reply-to: <20210722124814.778059-7-arnd@kernel.org>
- References: <20210722124814.778059-1-arnd@kernel.org> <20210722124814.778059-7-arnd@kernel.org>
- User-agent: Mutt/1.5.17 (2007-11-01)
On Thu, Jul 22, 2021 at 02:48:11PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> Remove the microblaze implemenation of strncpy/strnlen and instead use
> the generic versions. The microblaze version is fairly slow because it
> always does byte accesses even for aligned data, and it lacks a checks
> for user_addr_max().
Looks good,
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]