Re: [PATCH -tip v7 10/13] x86/kprobes: Push a fake return address at kretprobe_trampoline
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Masami Hiramatsu <mhiramat@xxxxxxxxxx>
- Subject: Re: [PATCH -tip v7 10/13] x86/kprobes: Push a fake return address at kretprobe_trampoline
- From: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
- Date: Wed, 16 Jun 2021 23:41:00 -0500
- Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, X86 ML <x86@xxxxxxxxxx>, Daniel Xu <dxu@xxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, bpf@xxxxxxxxxxxxxxx, kuba@xxxxxxxxxx, mingo@xxxxxxxxxx, ast@xxxxxxxxxx, tglx@xxxxxxxxxxxxx, kernel-team@xxxxxx, yhs@xxxxxx, linux-ia64@xxxxxxxxxxxxxxx, Abhishek Sagar <sagar.abhishek@xxxxxxxxx>, Andrii Nakryiko <andrii.nakryiko@xxxxxxxxx>
- In-reply-to: <162209763886.436794.6585363781863933939.stgit@devnote2>
- References: <162209754288.436794.3904335049560916855.stgit@devnote2> <162209763886.436794.6585363781863933939.stgit@devnote2>
On Thu, May 27, 2021 at 03:40:39PM +0900, Masami Hiramatsu wrote:
> This changes x86/kretprobe stack frame on kretprobe_trampoline
> a bit, which now push the kretprobe_trampoline as a fake return
> address at the bottom of the stack frame. With this fix, the ORC
> unwinder will see the kretprobe_trampoline as a return address.
>
> Signed-off-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>
> Suggested-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
> Tested-by: Andrii Nakryik <andrii@xxxxxxxxxx>
Acked-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
--
Josh
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]
