On Sat, Feb 6, 2021 at 8:07 AM John Paul Adrian Glaubitz <glaubitz@xxxxxxxxxxxxxxxxxxx> wrote: > > Hi Amy! > > On 2/5/21 11:06 PM, Amy Parker wrote: > > Some statements do not have proper spacing between their C > > keywords (commonly if and for) throughout files in the ia64 tree. > > This patch corrects this to follow the kernel code style guide. > > > > Signed-off-by: Amy Parker <enbyamy@xxxxxxxxx> > > I never noticed. Does the kernel coding style guideline actually require > space after "for" and "if" and similar statements but not before function > names? Yes it does, actually! > So use a space after these keywords: > if, switch, case, for, do, while > int system_is_up(void) > { > return system_state == SYSTEM_RUNNING; > } -Amy IP