Re: [PATCH 1/3] mm: replace memmap_context by memplug_context
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Laurent Dufour <ldufour@xxxxxxxxxxxxx>, akpm@xxxxxxxxxxxxxxxxxxxx, Oscar Salvador <osalvador@xxxxxxx>, mhocko@xxxxxxxxxx, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
- Subject: Re: [PATCH 1/3] mm: replace memmap_context by memplug_context
- From: David Hildenbrand <david@xxxxxxxxxx>
- Date: Fri, 11 Sep 2020 19:34:25 +0200
- Cc: linux-mm@xxxxxxxxx, "Rafael J . Wysocki" <rafael@xxxxxxxxxx>, nathanl@xxxxxxxxxxxxx, cheloha@xxxxxxxxxxxxx, Tony Luck <tony.luck@xxxxxxxxx>, Fenghua Yu <fenghua.yu@xxxxxxxxx>, linux-ia64@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
- In-reply-to: <6552ef9a-ac02-e79f-2eb6-08380ba4b478@linux.ibm.com>
- Organization: Red Hat GmbH
- References: <20200911134831.53258-1-ldufour@linux.ibm.com> <20200911134831.53258-2-ldufour@linux.ibm.com> <09528ef5-29fd-056d-4e58-fc13e55f418f@redhat.com> <6552ef9a-ac02-e79f-2eb6-08380ba4b478@linux.ibm.com>
- User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0
On 11.09.20 18:23, Laurent Dufour wrote:
> Le 11/09/2020 à 16:59, David Hildenbrand a écrit :
>>> struct page *start;
>>> struct memmap_init_callback_data args;
>>> diff --git a/include/linux/memory_hotplug.h b/include/linux/memory_hotplug.h
>>> index 375515803cd8..cd2bd21d3a4d 100644
>>> --- a/include/linux/memory_hotplug.h
>>> +++ b/include/linux/memory_hotplug.h
>>> @@ -15,6 +15,15 @@ struct memory_block;
>>> struct resource;
>>> struct vmem_altmap;
>>>
>>> +/*
>>> + * Memory plugin context, use to differentiate memory added at boot time and
>>
>> "Memory plugin context" sounds weird.
>
> Any suggestion ?
>
I'm not a native speaker, but "plugin" sounds weird in this context.
Maybe simply drop it and start right away with "Differentiate memory
added ..."
--
Thanks,
David / dhildenb
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]