Re: [PATCH v2] kbuild: preprocess module linker script
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Masahiro Yamada <masahiroy@xxxxxxxxxx>
- Subject: Re: [PATCH v2] kbuild: preprocess module linker script
- From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
- Date: Tue, 8 Sep 2020 08:59:48 +0200
- Cc: linux-kbuild <linux-kbuild@xxxxxxxxxxxxxxx>, "linux-ia64@xxxxxxxxxxxxxxx" <linux-ia64@xxxxxxxxxxxxxxx>, Catalin Marinas <catalin.marinas@xxxxxxx>, Paul Mackerras <paulus@xxxxxxxxx>, linux-riscv <linux-riscv@xxxxxxxxxxxxxxxxxxx>, Will Deacon <will@xxxxxxxxxx>, Anton Ivanov <anton.ivanov@xxxxxxxxxxxxxxxxxx>, Linux-Arch <linux-arch@xxxxxxxxxxxxxxx>, Richard Weinberger <richard@xxxxxx>, Russell King <linux@xxxxxxxxxxxxxxx>, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>, Fenghua Yu <fenghua.yu@xxxxxxxxx>, Albert Ou <aou@xxxxxxxxxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Jeff Dike <jdike@xxxxxxxxxxx>, Jessica Yu <jeyu@xxxxxxxxxx>, linux-um <linux-um@xxxxxxxxxxxxxxxxxxx>, linux-m68k <linux-m68k@xxxxxxxxxxxxxxx>, Michal Marek <michal.lkml@xxxxxxxxxxx>, Paul Walmsley <paul.walmsley@xxxxxxxxxx>, Linux ARM <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, Tony Luck <tony.luck@xxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Palmer Dabbelt <palmer@xxxxxxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, linuxppc-dev <linuxppc-dev@xxxxxxxxxxxxxxxx>
- In-reply-to: <20200908042708.2511528-1-masahiroy@kernel.org>
- References: <20200908042708.2511528-1-masahiroy@kernel.org>
On Tue, Sep 8, 2020 at 6:29 AM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
> There was a request to preprocess the module linker script like we
> do for the vmlinux one. (https://lkml.org/lkml/2020/8/21/512)
>
> The difference between vmlinux.lds and module.lds is that the latter
> is needed for external module builds, thus must be cleaned up by
> 'make mrproper' instead of 'make clean'. Also, it must be created
> by 'make modules_prepare'.
>
> You cannot put it in arch/$(SRCARCH)/kernel/, which is cleaned up by
> 'make clean'. I moved arch/$(SRCARCH)/kernel/module.lds to
> arch/$(SRCARCH)/include/asm/module.lds.h, which is included from
> scripts/module.lds.S.
>
> scripts/module.lds is fine because 'make clean' keeps all the
> build artifacts under scripts/.
>
> You can add arch-specific sections in <asm/module.lds.h>.
>
> Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>
> Tested-by: Jessica Yu <jeyu@xxxxxxxxxx>
> Acked-by: Will Deacon <will@xxxxxxxxxx>
> arch/m68k/Makefile | 1 -
> .../{kernel/module.lds => include/asm/module.lds.h} | 0
Acked-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]