Re: [PATCH] kbuild: preprocess module linker script
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Masahiro Yamada <masahiroy@xxxxxxxxxx>
- Subject: Re: [PATCH] kbuild: preprocess module linker script
- From: Will Deacon <will@xxxxxxxxxx>
- Date: Mon, 7 Sep 2020 14:30:30 +0100
- Cc: linux-kbuild@xxxxxxxxxxxxxxx, Ingo Molnar <mingo@xxxxxxxxxx>, Jessica Yu <jeyu@xxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Ard Biesheuvel <ardb@xxxxxxxxxx>, Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>, Albert Ou <aou@xxxxxxxxxxxxxxxxx>, Anton Ivanov <anton.ivanov@xxxxxxxxxxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>, Catalin Marinas <catalin.marinas@xxxxxxx>, Fenghua Yu <fenghua.yu@xxxxxxxxx>, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>, Jeff Dike <jdike@xxxxxxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Michal Marek <michal.lkml@xxxxxxxxxxx>, Palmer Dabbelt <palmer@xxxxxxxxxxx>, Paul Mackerras <paulus@xxxxxxxxx>, Paul Walmsley <paul.walmsley@xxxxxxxxxx>, Richard Weinberger <richard@xxxxxx>, Russell King <linux@xxxxxxxxxxxxxxx>, Tony Luck <tony.luck@xxxxxxxxx>, linux-arch@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-m68k@xxxxxxxxxxxxxxx, linux-riscv@xxxxxxxxxxxxxxxxxxx, linux-um@xxxxxxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx
- In-reply-to: <20200904133122.133071-1-masahiroy@kernel.org>
- References: <20200904133122.133071-1-masahiroy@kernel.org>
- User-agent: Mutt/1.10.1 (2018-07-13)
On Fri, Sep 04, 2020 at 10:31:21PM +0900, Masahiro Yamada wrote:
> There was a request to preprocess the module linker script like we do
> for the vmlinux one (https://lkml.org/lkml/2020/8/21/512).
>
> The difference between vmlinux.lds and module.lds is that the latter
> is needed for external module builds, thus must be cleaned up by
> 'make mrproper' instead of 'make clean' (also, it must be created by
> 'make modules_prepare').
>
> You cannot put it in arch/*/kernel/ because 'make clean' descends into
> it. I moved arch/*/kernel/module.lds to arch/*/include/asm/module.lds.h,
> which is included from scripts/module.lds.S.
>
> scripts/module.lds is fine because 'make clean' keeps all the build
> artifacts under scripts/.
>
> You can add arch-specific sections in <asm/module.lds.h>.
>
> Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>
> Tested-by: Jessica Yu <jeyu@xxxxxxxxxx>
> ---
For the arm64 bits:
Acked-by: Will Deacon <will@xxxxxxxxxx>
Thanks,
Will
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]