Re: [RESEND][PATCH 0/7] Avoid overflow at boundary_size
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Nicolin Chen <nicoleotsuka@xxxxxxxxx>
- Subject: Re: [RESEND][PATCH 0/7] Avoid overflow at boundary_size
- From: Christoph Hellwig <hch@xxxxxx>
- Date: Tue, 1 Sep 2020 11:11:05 +0200
- Cc: Christoph Hellwig <hch@xxxxxx>, mpe@xxxxxxxxxxxxxx, benh@xxxxxxxxxxxxxxxxxxx, paulus@xxxxxxxxx, rth@xxxxxxxxxxx, ink@xxxxxxxxxxxxxxxxxxxx, mattst88@xxxxxxxxx, tony.luck@xxxxxxxxx, fenghua.yu@xxxxxxxxx, schnelle@xxxxxxxxxxxxx, gerald.schaefer@xxxxxxxxxxxxx, hca@xxxxxxxxxxxxx, gor@xxxxxxxxxxxxx, borntraeger@xxxxxxxxxx, davem@xxxxxxxxxxxxx, tglx@xxxxxxxxxxxxx, mingo@xxxxxxxxxx, bp@xxxxxxxxx, x86@xxxxxxxxxx, hpa@xxxxxxxxx, James.Bottomley@xxxxxxxxxxxxxxxxxxxxx, deller@xxxxxx, sfr@xxxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-alpha@xxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, linux-parisc@xxxxxxxxxxxxxxx
- In-reply-to: <20200901075401.GA5667@Asurada-Nvidia>
- References: <20200831203811.8494-1-nicoleotsuka@gmail.com> <20200901073623.GA30418@lst.de> <20200901075401.GA5667@Asurada-Nvidia>
- User-agent: Mutt/1.5.17 (2007-11-01)
On Tue, Sep 01, 2020 at 12:54:01AM -0700, Nicolin Chen wrote:
> Hi Christoph,
>
> On Tue, Sep 01, 2020 at 09:36:23AM +0200, Christoph Hellwig wrote:
> > I really don't like all the open coded smarts in the various drivers.
> > What do you think about a helper like the one in the untested patch
>
> A helper function will be actually better. I was thinking of
> one yet not very sure about the naming and where to put it.
>
> > below (on top of your series). Also please include the original
> > segment boundary patch with the next resend so that the series has
> > the full context.
>
> I will use your change instead and resend with the ULONG_MAX
> change. But in that case, should I make separate changes for
> different files like this series, or just one single change
> like yours?
>
> Asking this as I was expecting that those changes would get
> applied by different maintainers. But now it feels like you
> will merge it to your tree at once?
I guess one patch is fine. I can queue it up in the dma-mapping
tree as a prep patch for the default boundary change.
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]