Re: [ALTERNATE PATCH] memblock: fix min_low_pfn/max_low_pfn build errors
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Mike Rapoport <rppt@xxxxxxxxxxxxx>
- Subject: Re: [ALTERNATE PATCH] memblock: fix min_low_pfn/max_low_pfn build errors
- From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
- Date: Sat, 29 Aug 2020 08:40:51 -0700
- Cc: linux-kernel@xxxxxxxxxxxxxxx, kernel test robot <lkp@xxxxxxxxx>, David Rientjes <rientjes@xxxxxxxxxx>, linux-mm@xxxxxxxxx, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Michal Simek <monstr@xxxxxxxxx>, Michal Simek <michal.simek@xxxxxxxxxx>, Tony Luck <tony.luck@xxxxxxxxx>, Fenghua Yu <fenghua.yu@xxxxxxxxx>, linux-ia64@xxxxxxxxxxxxxxx
- In-reply-to: <20200829130429.GG167163@linux.ibm.com>
- References: <20200829000139.2513-1-rdunlap@infradead.org> <20200829130429.GG167163@linux.ibm.com>
- User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0
On 8/29/20 6:04 AM, Mike Rapoport wrote:
> On Fri, Aug 28, 2020 at 05:01:39PM -0700, Randy Dunlap wrote:
>> Export min_low_pfn & max_low_pfn in mm/memblock.c to fix build errors
>> on arch/microblaze/ and arch/ia64/: (e.g.)
>
> Please don't. This would give driver developers a wrong impression that
> these variables can be used to query memory boundaries, but this is not
> the case, at least not on all architectures.
>
> I would prefer fixing it up locally for microblaze and ia64.
I did that.
and that's why this is labeled as an ALTERNATE PATCH.
thanks.
--
~Randy
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]