Re: [PATCH 05/28] media/v4l2: remove V4L2-FLAG-MEMORY-NON-CONSISTENT
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Tomasz Figa <tfiga@xxxxxxxxxxxx>
- Subject: Re: [PATCH 05/28] media/v4l2: remove V4L2-FLAG-MEMORY-NON-CONSISTENT
- From: Christoph Hellwig <hch@xxxxxx>
- Date: Wed, 19 Aug 2020 15:57:38 +0200
- Cc: Robin Murphy <robin.murphy@xxxxxxx>, Christoph Hellwig <hch@xxxxxx>, alsa-devel@xxxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, Linux Doc Mailing List <linux-doc@xxxxxxxxxxxxxxx>, nouveau@xxxxxxxxxxxxxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, "James E.J. Bottomley" <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>, linux-mm@xxxxxxxxx, Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>, linux-samsung-soc <linux-samsung-soc@xxxxxxxxxxxxxxx>, Joonyoung Shim <jy0922.shim@xxxxxxxxxxx>, linux-scsi@xxxxxxxxxxxxxxx, Kyungmin Park <kyungmin.park@xxxxxxxxxxx>, Ben Skeggs <bskeggs@xxxxxxxxxx>, Matt Porter <mporter@xxxxxxxxxxxxxxxxxxx>, Linux Media Mailing List <linux-media@xxxxxxxxxxxxxxx>, Tom Lendacky <thomas.lendacky@xxxxxxx>, Pawel Osciak <pawel@xxxxxxxxxx>, Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>, "list@xxxxxxx:IOMMU DRIVERS" <iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx>, Joerg Roedel <joro@xxxxxxxxxx>, "list@xxxxxxx:IOMMU DRIVERS <iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx>, Joerg Roedel <joro@xxxxxxxxxx>," <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>, linux-parisc@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, Seung-Woo Kim <sw0312.kim@xxxxxxxxxxx>, linux-mips@xxxxxxxxxxxxxxx
- In-reply-to: <CAAFQd5AcCTDguB2C9KyDiutXWoEvBL8tL7+a==Uo8vj_8CLOJw@mail.gmail.com>
- References: <20200819065555.1802761-1-hch@lst.de> <20200819065555.1802761-6-hch@lst.de> <CAAFQd5COLxjydDYrfx47ht8tj-aNPiaVnC+WyQA7nvpW4gs=ww@mail.gmail.com> <62e4f4fc-c8a5-3ee8-c576-fe7178cb4356@arm.com> <CAAFQd5AcCTDguB2C9KyDiutXWoEvBL8tL7+a==Uo8vj_8CLOJw@mail.gmail.com>
- User-agent: Mutt/1.5.17 (2007-11-01)
On Wed, Aug 19, 2020 at 02:49:01PM +0200, Tomasz Figa wrote:
> With the default config it doesn't, but with
> CONFIG_DMA_NONCOHERENT_CACHE_SYNC enabled it makes dma_pgprot() keep
> the pgprot value as is, without enforcing coherence attributes.
Which isn't selected on arm64, and that is for a good reason.
> AFAIK dma_cache_sync() isn't the only way to perform the cache
> synchronization.
Yes, it is the only documented way to do it. And if you read the whole
series instead of screaming you'd see that it provides a proper way
to deal with non-coherent memory which will also work with arm64.
instead of screaming
> By the way, as a videobuf2 reviewer, I'd appreciate being CC'd on any
> series related to the subsystem-facing DMA API changes, since
> videobuf2 is one of the biggest users of it.
The cc list is too long - I cc lists and key maintainers. As a reviewer
should should watch your subsystems lists closely.
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]