On Mon, May 18, 2020 at 02:08:55PM +0200, Krzysztof Kozlowski wrote: > There is a generic, kernel wide configuration symbol for enabling the > IOMMU specific bits: CONFIG_IOMMU_API. Implementations (including > INTEL_IOMMU and AMD_IOMMU driver) select it so use it here as well. > > This makes the conditional archdata.iommu field consistent with other > platforms and also fixes any compile test builds of other IOMMU drivers, > when INTEL_IOMMU or AMD_IOMMU are not selected). > > For the case when INTEL_IOMMU/AMD_IOMMU and COMPILE_TEST are not > selected, this should create functionally equivalent code/choice. With > COMPILE_TEST this field could appear if other IOMMU drivers are chosen > but neither INTEL_IOMMU nor AMD_IOMMU are not. > > Reported-by: kbuild test robot <lkp@xxxxxxxxx> > Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > --- > arch/x86/include/asm/device.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/include/asm/device.h b/arch/x86/include/asm/device.h > index 7e31f7f1bb06..49bd6cf3eec9 100644 > --- a/arch/x86/include/asm/device.h > +++ b/arch/x86/include/asm/device.h > @@ -3,7 +3,7 @@ > #define _ASM_X86_DEVICE_H > > struct dev_archdata { > -#if defined(CONFIG_INTEL_IOMMU) || defined(CONFIG_AMD_IOMMU) > +#ifdef CONFIG_IOMMU_API > void *iommu; /* hook for IOMMU specific extension */ > #endif > }; Acked-by: Borislav Petkov <bp@xxxxxxx> -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette